Refactor ConsulSchema specs

spec/lib/graphql_spec.rb

@@ -1,6 +1,5 @@
 require 'rails_helper'
 
-# TODO: uno por cada tipo escalar, uno por cada asociacion, uno con query anidada * 2 (uno para asegurarse de que se muestra y otro para cuando se oculta)
 def execute(query_string, context = {}, variables = {})
   ConsulSchema.execute(query_string, context: context, variables: variables)
 end
@@ -9,9 +8,15 @@ def dig(response, path)
   response.dig(*path.split('.'))
 end
 
+def hidden_field?(response, field_name)
+  data_is_empty = response['data'].nil?
+  error_is_present = ((response['errors'].first['message'] =~ /Field '#{field_name}' doesn't exist on type '[[:alnum:]]*'/) == 0)
+  data_is_empty && error_is_present
+end
+
 describe ConsulSchema do
-  let(:proposal_author) { create(:user) }
+  let(:user) { create(:user) }
-  let(:proposal) { create(:proposal, author: proposal_author) }
+  let(:proposal) { create(:proposal, author: user) }
 
   it "returns fields of Int type" do
     response = execute("{ proposal(id: #{proposal.id}) { id } }")
@@ -46,112 +51,45 @@ describe ConsulSchema do
     expect(comment_bodies).to match_array([comment_1.body, comment_2.body])
   end
 
-  # it "hides confidential fields of Int type" do
+  it "executes deeply nested queries" do
-  #   response = execute("{ user(id: #{user.id}) { failed_census_calls_count } }")
+    org_user = create(:user)
-  #   expect(response['data']).to be_nil
+    organization = create(:organization, user: org_user)
-  #   expect(response[])
+    org_proposal = create(:proposal, author: org_user)
-  # end
+    response = execute("{ proposal(id: #{org_proposal.id}) { author { organization { name } } } }")
-  #
+
-  # it "hides confidential fields of String type" do
+    expect(dig(response, 'data.proposal.author.organization.name')).to eq(organization.name)
-  #   skip
+  end
-  #   response = execute("{ user(id: #{user.id}) { encrypted_password } }")
+
-  # end
+  it "hides confidential fields of Int type" do
-  #
+    response = execute("{ user(id: #{user.id}) { failed_census_calls_count } }")
-  # it "hides confidential has_one associations" do
+    expect(hidden_field?(response, 'failed_census_calls_count')).to be_truthy
-  #   skip
+  end
-  #   response = execute("{ user(id: #{user.id}) { administrator { id } } }")
+
-  # end
+  it "hides confidential fields of String type" do
-  #
+    response = execute("{ user(id: #{user.id}) { encrypted_password } }")
-  # it "hides confidential belongs_to associations" do
+    expect(hidden_field?(response, 'encrypted_password')).to be_truthy
-  #   skip
+  end
-  #   response = execute("{ user(id: #{user.id}) { failed_census_calls { id } } }")
+
-  # end
+  it "hides confidential has_one associations" do
-  #
+    user.administrator = create(:administrator)
-  # it "hides confidential has_many associations" do
+    response = execute("{ user(id: #{user.id}) { administrator { id } } }")
-  #   skip
+    expect(hidden_field?(response, 'administrator')).to be_truthy
-  #   response = execute("{ user(id: #{user.id}) { direct_messages_sent { id } } }")
+  end
-  # end
+
-  #
+  it "hides confidential belongs_to associations" do
-  #   describe "do not expose confidential" do
+    create(:failed_census_call, user: user)
-  #     let(:user) { create(:user) }
+    response = execute("{ user(id: #{user.id}) { failed_census_calls { id } } }")
-  #     subject(:data) { response['data'] }
+    expect(hidden_field?(response, 'failed_census_calls')).to be_truthy
-  #     subject(:errors) { response['errors'] }
+  end
-  #     subject(:error_msg) { errors.first['message'] }
+
-  #
+  it "hides confidential has_many associations" do
-  #     describe "fields of Int type" do
+    create(:direct_message, sender: user)
-  #       let(:query_string) { "{ user(id: #{user.id}) { failed_census_calls_count } }" }
+    response = execute("{ user(id: #{user.id}) { direct_messages_sent { id } } }")
-  #
+    expect(hidden_field?(response, 'direct_messages_sent')).to be_truthy
-  #       specify { expect(data).to be_nil }
+  end
-  #       specify { expect(error_msg).to eq("Field 'failed_census_calls_count' doesn't exist on type 'User'") }
+
-  #     end
+  it "hides confidential fields inside deeply nested queries" do
-  #
+    response = execute("{ proposals(first: 1) { edges { node { author { encrypted_password } } } } }")
-  #     describe "fields of String type" do
+    expect(hidden_field?(response, 'encrypted_password')).to be_truthy
-  #       let(:query_string) { "{ user(id: #{user.id}) { encrypted_password } }" }
+  end
-  #
-  #       specify { expect(data).to be_nil }
-  #       specify { expect(error_msg).to eq("Field 'encrypted_password' doesn't exist on type 'User'") }
-  #     end
-  #
-  #     describe "fields inside nested queries" do
-  #       let(:proposal) { create(:proposal, author: user) }
-  #       let(:query_string) { "{ proposal(id: #{proposal.id}) { author { reset_password_sent_at } } }" }
-  #
-  #       specify { expect(data).to be_nil }
-  #       specify { expect(error_msg).to eq("Field 'reset_password_sent_at' doesn't exist on type 'User'") }
-  #     end
-  #
-  #     describe ":has_one associations" do
-  #       let(:administrator) { create(:administrator) }
-  #       let(:query_string) { "{ user(id: #{user.id}) { administrator { id } } }" }
-  #
-  #       specify { expect(data).to be_nil }
-  #       specify { expect(error_msg).to eq("Field 'administrator' doesn't exist on type 'User'") }
-  #     end
-  #
-  #     describe ":belongs_to associations" do
-  #       let(:query_string) { "{ user(id: #{user.id}) { failed_census_calls { id } } }" }
-  #       let(:census_call) { create(:failed_census_call, user: user) }
-  #
-  #       specify { expect(data).to be_nil }
-  #       specify { expect(error_msg).to eq("Field 'failed_census_calls' doesn't exist on type 'User'") }
-  #     end
-  #
-  #     describe ":has_many associations" do
-  #       let(:message) { create(:direct_message, sender: user) }
-  #       let(:query_string) { "{ user(id: #{user.id}) { direct_messages_sent { id } } }" }
-  #
-  #       specify { expect(data).to be_nil }
-  #       specify { expect(error_msg).to eq("Field 'direct_messages_sent' doesn't exist on type 'User'") }
-  #     end
-  #   end
-  #
-  # describe "queries to collections" do
-  #   let(:mrajoy) { create(:user, username: 'mrajoy') }
-  #   let(:dtrump) { create(:user, username: 'dtrump') }
-  #   let!(:proposal_1) { create(:proposal, id: 1, title: "Bajar el IVA", author: mrajoy) }
-  #   let!(:proposal_2) { create(:proposal, id: 2, title: "Censurar los memes", author: mrajoy) }
-  #   let!(:proposal_3) { create(:proposal, id: 3, title: "Construir un muro", author: dtrump) }
-  #   subject(:returned_proposals) { response['data']['proposals']["edges"].collect { |edge| edge['node'] } }
-  #
-  #   describe "return fields of Int type" do
-  #     let(:query_string) { "{ proposals { edges { node { id } } } }" }
-  #     let(:ids) { returned_proposals.collect { |proposal| proposal['id'] } }
-  #
-  #     specify { expect(ids).to match_array([3, 1, 2]) }
-  #   end
-  #
-  #   describe "return fields of String type" do
-  #     let(:query_string) { "{ proposals { edges { node { title } } } }" }
-  #     let(:titles) { returned_proposals.collect { |proposal| proposal['title'] } }
-  #
-  #     specify { expect(titles).to match_array(['Construir un muro', 'Censurar los memes', 'Bajar el IVA']) }
-  #   end
-  #
-  #   describe "return nested fields" do
-  #     let(:query_string) { "{ proposals { edges { node { author { username } } } } }" }
-  #     let(:authors) { returned_proposals.collect { |proposal| proposal['author']['username'] } }
-  #
-  #     specify { expect(authors).to match_array(['mrajoy', 'dtrump', 'mrajoy']) }
-  #   end
-  # end
 end