From c78494c100c985a14815c52e2b79916bab574801 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Sat, 21 Aug 2021 00:29:07 +0200
Subject: [PATCH] Extract method to get toggle selection path

This way we simplify the view code.

Since now we only use the `budget` method in one place, we're removing
it.
---
 .../toggle_selection_component.html.erb       | 22 ++-----------------
 .../toggle_selection_component.rb             | 13 +++++++++--
 2 files changed, 13 insertions(+), 22 deletions(-)

diff --git a/app/components/admin/budget_investments/toggle_selection_component.html.erb b/app/components/admin/budget_investments/toggle_selection_component.html.erb
index 82b4a9165..97d671e67 100644
--- a/app/components/admin/budget_investments/toggle_selection_component.html.erb
+++ b/app/components/admin/budget_investments/toggle_selection_component.html.erb
@@ -1,32 +1,14 @@
 <% if investment.selected? %>
   <%= link_to_if can?(:toggle_selection, investment),
                  t("admin.budget_investments.index.selected"),
-                 toggle_selection_admin_budget_budget_investment_path(
-                   budget,
-                   investment,
-                   filter: params[:filter],
-                   sort_by: params[:sort_by],
-                   min_total_supports: params[:min_total_supports],
-                   max_total_supports: params[:max_total_supports],
-                   advanced_filters: params[:advanced_filters],
-                   page: params[:page]
-                 ),
+                 path,
                  method: :patch,
                  remote: true,
                  class: "button small expanded" %>
 <% elsif investment.feasible? && investment.valuation_finished? %>
   <% if can?(:toggle_selection, investment) %>
     <%= link_to t("admin.budget_investments.index.select"),
-                toggle_selection_admin_budget_budget_investment_path(
-                  budget,
-                  investment,
-                  filter: params[:filter],
-                  sort_by: params[:sort_by],
-                  min_total_supports: params[:min_total_supports],
-                  max_total_supports: params[:max_total_supports],
-                  advanced_filters: params[:advanced_filters],
-                  page: params[:page]
-                ),
+                path,
                 method: :patch,
                 remote: true,
                 class: "button small hollow expanded" %>
diff --git a/app/components/admin/budget_investments/toggle_selection_component.rb b/app/components/admin/budget_investments/toggle_selection_component.rb
index 312be4ba9..9dd870d86 100644
--- a/app/components/admin/budget_investments/toggle_selection_component.rb
+++ b/app/components/admin/budget_investments/toggle_selection_component.rb
@@ -8,7 +8,16 @@ class Admin::BudgetInvestments::ToggleSelectionComponent < ApplicationComponent
 
   private
 
-    def budget
-      investment.budget
+    def path
+      toggle_selection_admin_budget_budget_investment_path(
+        investment.budget,
+        investment,
+        filter: params[:filter],
+        sort_by: params[:sort_by],
+        min_total_supports: params[:min_total_supports],
+        max_total_supports: params[:max_total_supports],
+        advanced_filters: params[:advanced_filters],
+        page: params[:page]
+      )
     end
 end