+ <%= render 'documents/documents',
+ documents: @investment.documents,
+ max_documents_allowed: Budget::Investment.max_documents_allowed %>
+
+
diff --git a/app/views/documents/_document.html.erb b/app/views/documents/_document.html.erb
new file mode 100644
index 000000000..c4ead4c65
--- /dev/null
+++ b/app/views/documents/_document.html.erb
@@ -0,0 +1,20 @@
+
+ <%= render 'documents/nested_documents', documentable: @proposal %>
+
+
<%= f.label :geozone_id, t("proposals.form.geozone") %>
<%= f.select :geozone_id, geozone_select_options, {include_blank: t("geozones.none"), label: false} %>
diff --git a/app/views/proposals/show.html.erb b/app/views/proposals/show.html.erb
index 75c07873a..523c0961d 100644
--- a/app/views/proposals/show.html.erb
+++ b/app/views/proposals/show.html.erb
@@ -16,6 +16,12 @@
<%= back_link_to %>
+ <% if can?(:create, @document) && @proposal.documents.size < Proposal.max_documents_allowed %>
+ <%= link_to t("documents.upload_document"),
+ new_document_path(documentable_id: @proposal, documentable_type: @proposal.class.name, from: request.url),
+ class: 'button hollow float-right' %>
+ <% end %>
+
<% if author_of?(@proposal, current_user) %>
<%= link_to t("proposals.show.send_notification"), new_proposal_notification_path(proposal_id: @proposal.id),
class: 'button hollow float-right' %>
@@ -165,4 +171,10 @@
+
+
+ <%= render 'documents/documents',
+ documents: @proposal.documents,
+ max_documents_allowed: Proposal.max_documents_allowed %>
+
diff --git a/config/i18n-tasks.yml b/config/i18n-tasks.yml
index cc289ba3c..fde4d197f 100644
--- a/config/i18n-tasks.yml
+++ b/config/i18n-tasks.yml
@@ -37,6 +37,7 @@ data:
- config/locales/%{locale}/officing.yml
- config/locales/%{locale}/budgets.yml
- config/locales/%{locale}/legislation.yml
+ - config/locales/%{locale}/documents.yml
# Locale files to write new keys to, based on a list of key pattern => file rules. Matched from top to bottom:
# `i18n-tasks normalize -p` will force move the keys according to these rules
diff --git a/config/locales/en/activerecord.yml b/config/locales/en/activerecord.yml
index 06ce24fd6..79982150c 100644
--- a/config/locales/en/activerecord.yml
+++ b/config/locales/en/activerecord.yml
@@ -76,6 +76,9 @@ en:
legislation/answers:
one: "Answer"
other: "Answers"
+ documents:
+ one: "Document"
+ other: "Documents"
attributes:
budget:
name: "Name"
@@ -197,6 +200,9 @@ en:
value: Value
legislation/annotation:
text: Comment
+ document:
+ title: Title
+ attachment: Attachment
errors:
models:
user:
diff --git a/config/locales/en/documents.yml b/config/locales/en/documents.yml
new file mode 100644
index 000000000..d2485df4c
--- /dev/null
+++ b/config/locales/en/documents.yml
@@ -0,0 +1,35 @@
+en:
+ documents:
+ tab: Documents
+ no_documents: Don't have uploaded documents
+ upload_document: Upload document
+ max_documents_allowed_reached_html: You have reached the maximum number of documents allowed!
You have to delete one before you can upload another.
+ form:
+ title: Documents
+ attachment_label: Choose document
+ submit_button: Upload document
+ delete_button: Remove document
+ note: "You can upload up to a maximum of %{max_documents_allowed} documents of following content types: %{accepted_content_types}, up to %{max_file_size} MB per file."
+ add_new_document: Add new document
+ new:
+ title: Upload document
+ recommendations_title: File upload tips
+ recommendation_one_html: You can upload up to a
maximum of %{max_documents_allowed} documents.
+ recommendation_two_html: You can upload
%{accepted_content_types} files.
+ recommendation_three_html: You can upload files up to
%{max_file_size} MB.
+
+ actions:
+ create:
+ notice: Document was created successfully.
+ alert: Cannot create document. Check form errors and try again.
+ destroy:
+ notice: Document was deleted successfully.
+ alert: Cannot destroy document.
+ confirm: Are you sure you want to delete the document? This action cannot be undone!
+ buttons:
+ download_document: Dowload file
+ destroy_document: Destroy
+ errors:
+ messages:
+ in_between: must be in between %{min} and %{max}
+ wrong_content_type: content type %{content_type} does not match any of accepted content types %{accepted_content_types}
diff --git a/config/locales/en/general.yml b/config/locales/en/general.yml
index 5f25a3440..74063e84d 100644
--- a/config/locales/en/general.yml
+++ b/config/locales/en/general.yml
@@ -181,6 +181,7 @@ en:
user: Account
verification/sms: phone
signature_sheet: Signature sheet
+ document: Document
geozones:
none: All city
all: All scopes
diff --git a/config/locales/es/activerecord.yml b/config/locales/es/activerecord.yml
index d00b4ab88..d409d1c5e 100644
--- a/config/locales/es/activerecord.yml
+++ b/config/locales/es/activerecord.yml
@@ -76,6 +76,9 @@ es:
legislation/answers:
one: "Respuesta"
other: "Respuestas"
+ documents:
+ one: "Documento"
+ other: "Documentos"
attributes:
budget:
name: "Nombre"
@@ -192,6 +195,9 @@ es:
value: Valor
legislation/annotation:
text: Comentario
+ document:
+ title: Título
+ attachment: Archivo adjunto
errors:
models:
user:
diff --git a/config/locales/es/documents.yml b/config/locales/es/documents.yml
new file mode 100644
index 000000000..a0b646ecc
--- /dev/null
+++ b/config/locales/es/documents.yml
@@ -0,0 +1,34 @@
+es:
+ documents:
+ tab: Documentos
+ no_documents: No hay documentos subidos
+ upload_document: Subir documento
+ max_documents_allowed_reached_html: ¡Has alcanzado el número máximo de documentos permitidos!
Tienes que eliminar uno antes de poder subir otro.
+ form:
+ title: Documentos
+ attachment_label: Selecciona un documento
+ submit_button: Subir documento
+ delete_button: Eliminar documento
+ note: "Puedes subir hasta un máximo de %{max_documents_allowed} documentos en los formatos: %{accepted_content_types}, y de hasta %{max_file_size} MB por archivo."
+ add_new_document: Añadir nuevo documento
+ new:
+ title: Subir un documento
+ recommendations_title: Consejos para subir archivos
+ recommendation_one_html: Puedes subir hasta un máximo de
%{max_documents_allowed} documentos
+ recommendation_two_html: Sólo puedes subir
archivos %{accepted_content_types}.
+ recommendation_three_html: Puedes subir archivos de hasta
%{max_file_size} MB
+ actions:
+ create:
+ notice: "El documento se ha creado correctamente."
+ alert: "El documento no se ha podido crear. Revise los errores del formulario."
+ destroy:
+ notice: "El documento se ha eliminado correctamente."
+ alert: "El documento no se ha podido eliminar."
+ confirm: "¿Está seguro de que desea eliminar el documento? Esta acción no se puede deshacer!"
+ buttons:
+ download_document: Descargar archivo
+ destroy_document: Eliminar
+ errors:
+ messages:
+ in_between: debe estar entre %{min} y %{max}
+ wrong_content_type: El tipo de contenido %{content_type} del archivo no coincide con ninguno de los tipos de contenido aceptados %{accepted_content_types}
diff --git a/config/locales/es/general.yml b/config/locales/es/general.yml
index d6c68b49f..c073a98c2 100644
--- a/config/locales/es/general.yml
+++ b/config/locales/es/general.yml
@@ -181,6 +181,7 @@ es:
user: la cuenta
verification/sms: el teléfono
signature_sheet: la hoja de firmas
+ document: el documento
geozones:
none: Toda la ciudad
all: Todos los ámbitos de actuación
diff --git a/config/routes.rb b/config/routes.rb
index d151fdb6c..46751fd48 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -95,6 +95,14 @@ Rails.application.routes.draw do
resources :follows, only: [:create, :destroy]
+ resources :documents, only: [:new, :create, :destroy] do
+ collection do
+ get :new_nested
+ delete :destroy_upload
+ post :upload
+ end
+ end
+
resources :stats, only: [:index]
resources :legacy_legislations, only: [:show], path: 'legislations'
diff --git a/db/migrate/20170720092638_create_documents.rb b/db/migrate/20170720092638_create_documents.rb
new file mode 100644
index 000000000..b7d1e287c
--- /dev/null
+++ b/db/migrate/20170720092638_create_documents.rb
@@ -0,0 +1,14 @@
+class CreateDocuments < ActiveRecord::Migration
+ def change
+ create_table :documents do |t|
+ t.string :title
+ t.attachment :attachment
+ t.references :user, index: true, foreign_key: true
+ t.references :documentable, polymorphic: true, index: true
+
+ t.timestamps null: false
+ end
+
+ add_index :documents, [:user_id, :documentable_type, :documentable_id], name: "access_documents"
+ end
+end
diff --git a/db/schema.rb b/db/schema.rb
index f12afd6a6..7f37aa137 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -11,7 +11,7 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema.define(version: 20170719174326) do
+ActiveRecord::Schema.define(version: 20170720092638) do
# These are extensions that must be enabled in order to support this database
enable_extension "plpgsql"
@@ -298,6 +298,23 @@ ActiveRecord::Schema.define(version: 20170719174326) do
t.datetime "updated_at", null: false
end
+ create_table "documents", force: :cascade do |t|
+ t.string "title"
+ t.string "attachment_file_name"
+ t.string "attachment_content_type"
+ t.integer "attachment_file_size"
+ t.datetime "attachment_updated_at"
+ t.integer "user_id"
+ t.integer "documentable_id"
+ t.string "documentable_type"
+ t.datetime "created_at", null: false
+ t.datetime "updated_at", null: false
+ end
+
+ add_index "documents", ["documentable_type", "documentable_id"], name: "index_documents_on_documentable_type_and_documentable_id", using: :btree
+ add_index "documents", ["user_id", "documentable_type", "documentable_id"], name: "access_documents", using: :btree
+ add_index "documents", ["user_id"], name: "index_documents_on_user_id", using: :btree
+
create_table "failed_census_calls", force: :cascade do |t|
t.integer "user_id"
t.string "document_number"
@@ -1014,6 +1031,7 @@ ActiveRecord::Schema.define(version: 20170719174326) do
add_foreign_key "administrators", "users"
add_foreign_key "annotations", "legacy_legislations"
add_foreign_key "annotations", "users"
+ add_foreign_key "documents", "users"
add_foreign_key "failed_census_calls", "poll_officers"
add_foreign_key "failed_census_calls", "users"
add_foreign_key "flags", "users"
diff --git a/spec/factories.rb b/spec/factories.rb
index 24c0767d4..7b1f6a417 100644
--- a/spec/factories.rb
+++ b/spec/factories.rb
@@ -368,6 +368,20 @@ FactoryGirl.define do
end
end
+ factory :document do
+ sequence(:title) { |n| "Document title #{n}" }
+ association :user, factory: :user
+ attachment { File.new("spec/fixtures/files/empty.pdf") }
+
+ trait :proposal_document do
+ association :documentable, factory: :proposal
+ end
+
+ trait :budget_investment_document do
+ association :documentable, factory: :budget_investment
+ end
+ end
+
factory :comment do
association :commentable, factory: :debate
user
diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb
index 96a26ad82..73a6f3677 100644
--- a/spec/features/budgets/investments_spec.rb
+++ b/spec/features/budgets/investments_spec.rb
@@ -429,7 +429,17 @@ feature 'Budget Investments' do
end
end
- it_behaves_like "followable", "budget_investment", "budget_investment_path", {"budget_id": "budget_id", "id": "id"}
+ it_behaves_like "followable", "budget_investment", "budget_investment_path", { "budget_id": "budget_id", "id": "id" }
+
+ it_behaves_like "documentable", "budget_investment", "budget_investment_path", {"budget_id": "budget_id", "id": "id"}
+
+ it_behaves_like "nested documentable",
+ "budget_investment",
+ "new_budget_investment_path",
+ { "budget_id": "budget_id" },
+ "fill_new_valid_budget_investment",
+ "Create Investment",
+ "Budget Investment created successfully."
context "Destroy" do
diff --git a/spec/features/proposals_spec.rb b/spec/features/proposals_spec.rb
index 353bcfecb..0856c53a8 100644
--- a/spec/features/proposals_spec.rb
+++ b/spec/features/proposals_spec.rb
@@ -1317,6 +1317,24 @@ feature 'Proposals' do
it_behaves_like "followable", "proposal", "proposal_path", { "id": "id" }
+ it_behaves_like "documentable", "proposal", "proposal_path", { "id": "id" }
+
+ it_behaves_like "nested documentable",
+ "proposal",
+ "new_proposal_path",
+ { },
+ "fill_new_valid_proposal",
+ "Create proposal",
+ "Proposal created successfully"
+
+ it_behaves_like "nested documentable",
+ "proposal",
+ "edit_proposal_path",
+ { "id": "id" },
+ nil,
+ "Save changes",
+ "Proposal updated successfully"
+
scenario 'Erased author' do
user = create(:user)
proposal = create(:proposal, author: user)
diff --git a/spec/fixtures/files/empty.pdf b/spec/fixtures/files/empty.pdf
new file mode 100644
index 000000000..de2e38148
Binary files /dev/null and b/spec/fixtures/files/empty.pdf differ
diff --git a/spec/models/abilities/administrator_spec.rb b/spec/models/abilities/administrator_spec.rb
index da872e353..bbec927a0 100644
--- a/spec/models/abilities/administrator_spec.rb
+++ b/spec/models/abilities/administrator_spec.rb
@@ -12,8 +12,12 @@ describe "Abilities::Administrator" do
let(:debate) { create(:debate) }
let(:comment) { create(:comment) }
let(:proposal) { create(:proposal) }
+ let(:budget_investment) { create(:budget_investment) }
let(:legislation_question) { create(:legislation_question) }
+ let(:proposal_document) { build(:document, documentable: proposal) }
+ let(:budget_investment_document) { build(:document, documentable: budget_investment) }
+
let(:hidden_debate) { create(:debate, :hidden) }
let(:hidden_comment) { create(:comment, :hidden) }
let(:hidden_proposal) { create(:proposal, :hidden) }
@@ -71,4 +75,12 @@ describe "Abilities::Administrator" do
it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, phase: 'valuating'))) }
it { should be_able_to(:valuate, create(:budget_investment, budget: create(:budget, phase: 'finished'))) }
+
+ it { should be_able_to(:new, proposal_document) }
+ it { should be_able_to(:create, proposal_document) }
+ it { should be_able_to(:destroy, proposal_document) }
+
+ it { should be_able_to(:new, budget_investment_document) }
+ it { should be_able_to(:create, budget_investment_document) }
+ it { should be_able_to(:destroy, budget_investment_document) }
end
diff --git a/spec/models/abilities/common_spec.rb b/spec/models/abilities/common_spec.rb
index da398e610..dfaac3598 100644
--- a/spec/models/abilities/common_spec.rb
+++ b/spec/models/abilities/common_spec.rb
@@ -54,6 +54,11 @@ describe "Abilities::Common" do
let(:incoming_poll_question_from_other_geozone) { create(:poll_question, poll: incoming_poll_from_other_geozone) }
let(:incoming_poll_question_from_all_geozones) { create(:poll_question, poll: incoming_poll) }
+ let(:own_proposal_document) { build(:document, documentable: own_proposal) }
+ let(:proposal_document) { build(:document, documentable: proposal) }
+ let(:own_budget_investment_document) { build(:document, documentable: own_investment_in_accepting_budget) }
+ let(:budget_investment_document) { build(:document, documentable: investment_in_accepting_budget) }
+
it { should be_able_to(:index, Debate) }
it { should be_able_to(:show, debate) }
it { should be_able_to(:vote, debate) }
@@ -82,6 +87,25 @@ describe "Abilities::Common" do
it { should_not be_able_to(:create, DirectMessage) }
it { should_not be_able_to(:show, DirectMessage) }
+ it { should be_able_to(:new_nested, Document) }
+ it { should be_able_to(:destroy_upload, Document) }
+
+ it { should be_able_to(:new, own_proposal_document) }
+ it { should be_able_to(:create, own_proposal_document) }
+ it { should be_able_to(:destroy, own_proposal_document) }
+
+ it { should_not be_able_to(:new, proposal_document) }
+ it { should_not be_able_to(:create, proposal_document) }
+ it { should_not be_able_to(:destroy, proposal_document) }
+
+ it { should be_able_to(:new, own_budget_investment_document) }
+ it { should be_able_to(:create, own_budget_investment_document) }
+ it { should be_able_to(:destroy, own_budget_investment_document) }
+
+ it { should_not be_able_to(:new, budget_investment_document) }
+ it { should_not be_able_to(:create, budget_investment_document) }
+ it { should_not be_able_to(:destroy, budget_investment_document) }
+
describe 'flagging content' do
it { should be_able_to(:flag, debate) }
it { should be_able_to(:unflag, debate) }
diff --git a/spec/models/document_spec.rb b/spec/models/document_spec.rb
new file mode 100644
index 000000000..bc5d4e923
--- /dev/null
+++ b/spec/models/document_spec.rb
@@ -0,0 +1,8 @@
+require 'rails_helper'
+
+describe Document do
+
+ it_behaves_like "document validations", "budget_investment_document"
+ it_behaves_like "document validations", "proposal_document"
+
+end
diff --git a/spec/shared/features/documentable.rb b/spec/shared/features/documentable.rb
new file mode 100644
index 000000000..b8b5ebe1c
--- /dev/null
+++ b/spec/shared/features/documentable.rb
@@ -0,0 +1,404 @@
+shared_examples "documentable" do |documentable_factory_name, documentable_path, documentable_path_arguments|
+ include ActionView::Helpers
+ include DocumentsHelper
+ include DocumentablesHelper
+
+ let!(:administrator) { create(:user) }
+ let!(:user) { create(:user) }
+ let!(:arguments) { {} }
+ let!(:documentable) { create(documentable_factory_name, author: user) }
+ let!(:documentable_dom_name) { documentable_factory_name.parameterize }
+
+ before do
+ create(:administrator, user: administrator)
+
+ documentable_path_arguments.each do |argument_name, path_to_value|
+ arguments.merge!("#{argument_name}": documentable.send(path_to_value))
+ end
+ end
+
+ context "Show" do
+
+ scenario "Should not display upload document button when there is no logged user" do
+ visit send(documentable_path, arguments)
+
+ within "##{dom_id(documentable)}" do
+ expect(page).not_to have_link("Upload document")
+ end
+ end
+
+ scenario "Should not display upload document button when maximum number of documents reached " do
+ create_list(:document, 3, documentable: documentable)
+ visit send(documentable_path, arguments)
+
+ within "##{dom_id(documentable)}" do
+ expect(page).not_to have_link("Upload document")
+ end
+ end
+
+ scenario "Should display upload document button when user is logged in and is documentable owner" do
+ login_as(user)
+
+ visit send(documentable_path, arguments)
+
+ within "##{dom_id(documentable)}" do
+ expect(page).to have_link("Upload document")
+ end
+ end
+
+ scenario "Should display upload document button when admin is logged in" do
+ login_as(administrator)
+
+ visit send(documentable_path, arguments)
+
+ within "##{dom_id(documentable)}" do
+ expect(page).to have_link("Upload document")
+ end
+ end
+
+ scenario "Should navigate to new document page when click un upload button" do
+ login_as(user)
+
+ visit send(documentable_path, arguments)
+ click_link "Upload document"
+
+ expect(page).to have_selector("h1", text: "Upload document")
+ end
+
+ describe "Documents tab" do
+
+ let!(:document) { create(:document, documentable: documentable, user: documentable.author)}
+
+ scenario "Should not display maximum number of documents alert when reached for users without document creation permission" do
+ create_list(:document, 2, documentable: documentable)
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).not_to have_content "You have reached the maximum number of documents allowed! You have to delete one before you can upload another."
+ end
+ end
+
+ scenario "Should display maximum number of documents alert when reached and when current user has document creation permission" do
+ login_as documentable.author
+ create_list(:document, 2, documentable: documentable)
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).to have_content "You have reached the maximum number of documents allowed! You have to delete one before you can upload another."
+ end
+ end
+
+ scenario "Download action should be able to anyone" do
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).to have_link("Dowload file")
+ end
+ end
+
+ scenario "Download file link should have blank target attribute" do
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).to have_selector("a[target=_blank]", text: "Dowload file")
+ end
+ end
+
+ scenario "Download file links should have rel attribute setted to no follow" do
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).to have_selector("a[rel=nofollow]", text: "Dowload file")
+ end
+ end
+
+ describe "Destroy action" do
+
+ scenario "Should not be able when no user logged in" do
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).not_to have_link("Destroy")
+ end
+ end
+
+ scenario "Should be able when documentable author is logged in" do
+ login_as documentable.author
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).to have_link("Destroy")
+ end
+ end
+
+ scenario "Should be able when any administrator logged in" do
+ login_as administrator
+ visit send(documentable_path, arguments)
+
+ within "#tab-documents" do
+ expect(page).to have_link("Destroy")
+ end
+ end
+
+ end
+
+ end
+
+ end
+
+ context "New" do
+
+ scenario "Should not be able for unathenticated users" do
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ expect(page).to have_content("You must sign in or register to continue.")
+ end
+
+ scenario "Should not be able for other users" do
+ login_as create(:user)
+
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ expect(page).to have_content("You do not have permission to carry out the action 'new' on document. ")
+ end
+
+ scenario "Should be able to documentable author" do
+ login_as documentable.author
+
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ expect(page).to have_selector("h1", text: "Upload document")
+ end
+
+ scenario "Should display file name after file selection", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf", make_visible: true
+ sleep 1
+
+ expect(page).to have_content "empty.pdf"
+ end
+
+ scenario "Should not display file name after file selection", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/logo_header.png", make_visible: true
+ sleep 1
+
+ expect(page).not_to have_content "logo_header.jpg"
+ end
+
+ scenario "Should update loading bar style after valid file upload", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf", make_visible: true
+ sleep 1
+
+ expect(page).to have_selector ".loading-bar.complete"
+ end
+
+ scenario "Should update loading bar style after unvalid file upload", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/logo_header.png", make_visible: true
+ sleep 1
+
+ expect(page).to have_selector ".loading-bar.errors"
+ end
+
+ scenario "Should update document title with attachment original file name after file selection if no title defined by user", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf", make_visible: true
+ sleep 1
+
+ expect(find("input[name='document[title]']").value).to eq("empty.pdf")
+ end
+
+ scenario "Should not update document title with attachment original file name after file selection when title already defined by user", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ fill_in :document_title, with: "My custom title"
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf", make_visible: true
+ sleep 1
+
+ expect(find("input[name='document[title]']").value).to eq("My custom title")
+ end
+
+ scenario "Should update document cached_attachment field after valid file upload", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf", make_visible: true
+ sleep 1
+
+ expect(find("input[name='document[cached_attachment]']", visible: false).value).to include("empty.pdf")
+ end
+
+ scenario "Should not update document cached_attachment field after unvalid file upload", :js do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ attach_file :document_attachment, "spec/fixtures/files/logo_header.png", make_visible: true
+ sleep 1
+
+ expect(find("input[name='document[cached_attachment]']", visible: false).value).to eq ""
+ end
+
+ scenario "Should show documentable custom recomentations" do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id,
+ from: send(documentable_path, arguments))
+
+ expect(page).to have_content "You can upload up to a maximum of #{max_file_size(documentable)} documents."
+ expect(page).to have_content "You can upload #{humanized_accepted_content_types(documentable)} files."
+ expect(page).to have_content "You can upload files up to #{max_file_size(documentable)} MB."
+ end
+
+ end
+
+ context "Create" do
+
+ scenario "Should show validation errors" do
+ login_as documentable.author
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id)
+
+ click_on "Upload document"
+
+ expect(page).to have_content "2 errors prevented this Document from being saved: "
+ expect(page).to have_selector "small.error", text: "can't be blank", count: 2
+ end
+
+ scenario "Should show error notice after unsuccessfull document upload" do
+ login_as documentable.author
+
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id,
+ from: send(documentable_path, arguments))
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf"
+ sleep 1
+ click_on "Upload document"
+
+ expect(page).to have_content "Cannot create document. Check form errors and try again."
+ end
+
+ scenario "Should show success notice after successfull document upload" do
+ login_as documentable.author
+
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id,
+ from: send(documentable_path, arguments))
+ fill_in :document_title, with: "Document title"
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf"
+ sleep 1
+ click_on "Upload document"
+
+ expect(page).to have_content "Document was created successfully."
+ end
+
+ scenario "Should redirect to documentable path after successfull document upload" do
+ login_as documentable.author
+
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id,
+ from: send(documentable_path, arguments))
+ fill_in :document_title, with: "Document title"
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf"
+ sleep 1
+ click_on "Upload document"
+
+ within "##{dom_id(documentable)}" do
+ expect(page).to have_selector "h1", text: documentable.title
+ end
+ end
+
+ scenario "Should show new document on documentable documents tab after successfull document upload" do
+ login_as documentable.author
+
+ visit new_document_path(documentable_type: documentable.class.name,
+ documentable_id: documentable.id,
+ from: send(documentable_path, arguments))
+ fill_in :document_title, with: "Document title"
+ attach_file :document_attachment, "spec/fixtures/files/empty.pdf"
+ sleep 1
+ click_on "Upload document"
+
+ expect(page).to have_link "Documents (1)"
+ within "#tab-documents" do
+ within "#document_#{Document.last.id}" do
+ expect(page).to have_content "Document title"
+ expect(page).to have_link "Dowload file"
+ expect(page).to have_link "Destroy"
+ end
+ end
+ end
+
+ end
+
+ context "Destroy" do
+
+ let!(:document) { create(:document, documentable: documentable, user: documentable.author) }
+
+ scenario "Should show success notice after successfull document upload" do
+ login_as documentable.author
+
+ visit send(documentable_path, arguments)
+ within "#tab-documents" do
+ within "#document_#{document.id}" do
+ click_on "Destroy"
+ end
+ end
+
+ expect(page).to have_content "Document was deleted successfully."
+ end
+
+ scenario "Should update documents tab count after successful deletion" do
+ login_as documentable.author
+
+ visit send(documentable_path, arguments)
+ within "#tab-documents" do
+ within "#document_#{document.id}" do
+ click_on "Destroy"
+ end
+ end
+
+ expect(page).to have_link "Documents (0)"
+ end
+
+ scenario "Should redirect to documentable path after successful deletion" do
+ login_as documentable.author
+
+ visit send(documentable_path, arguments)
+ within "#tab-documents" do
+ within "#document_#{document.id}" do
+ click_on "Destroy"
+ end
+ end
+
+ within "##{dom_id(documentable)}" do
+ expect(page).to have_selector "h1", text: documentable.title
+ end
+ end
+
+ end
+
+end
diff --git a/spec/shared/features/nested_documentable.rb b/spec/shared/features/nested_documentable.rb
new file mode 100644
index 000000000..d03841d36
--- /dev/null
+++ b/spec/shared/features/nested_documentable.rb
@@ -0,0 +1,265 @@
+shared_examples "nested documentable" do |documentable_factory_name, path, documentable_path_arguments, fill_resource_method_name, submit_button, documentable_success_notice|
+ include ActionView::Helpers
+ include DocumentsHelper
+ include DocumentablesHelper
+
+ let!(:administrator) { create(:user) }
+ let!(:user) { create(:user, :level_two) }
+ let!(:arguments) { {} }
+ let!(:documentable) { create(documentable_factory_name, author: user) }
+
+ before do
+ create(:administrator, user: administrator)
+
+ if documentable_path_arguments
+ documentable_path_arguments.each do |argument_name, path_to_value|
+ arguments.merge!("#{argument_name}": documentable.send(path_to_value))
+ end
+ end
+ end
+
+ describe "at #{path}" do
+
+ scenario "Should show new document link when max documents allowed limit is not reached" do
+ login_as user
+ visit send(path, arguments)
+
+ expect(page).to have_selector "#new_document_link", visible: true
+ end
+
+ scenario "Should not show new document link when documentable max documents allowed limit is reached", :js do
+ login_as user
+ visit send(path, arguments)
+
+ click_link "Add new document"
+ sleep 1
+ click_link "Add new document"
+ sleep 1
+ click_link "Add new document"
+
+ expect(page).to have_selector "#new_document_link", visible: false
+ end
+
+ scenario "Should not show max documents warning when no documents added", :js do
+ login_as user
+ visit send(path, arguments)
+
+ expect(page).to have_selector ".max-documents-notice", visible: false
+ end
+
+ scenario "Should show max documents warning when max documents allowed limit is reached", :js do
+ login_as user
+ visit send(path, arguments)
+
+ click_link "Add new document"
+ sleep 1
+ click_link "Add new document"
+ sleep 1
+ click_link "Add new document"
+
+ expect(page).to have_selector ".max-documents-notice", visible: true
+ end
+
+ scenario "Should hide max documents warning after any document removal", :js do
+ login_as user
+ visit send(path, arguments)
+
+ click_link "Add new document"
+ sleep 1
+ click_link "Add new document"
+ sleep 1
+ click_link "Add new document"
+ sleep 1
+ within "#document_0" do
+ find("a", text: "Remove document").click
+ end
+ sleep 1
+
+ expect(page).to have_selector ".max-documents-notice", visible: false
+ end
+
+ scenario "Should update nested document file name after choosing a file", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+
+ expect(page).to have_selector ".file-name", text: "empty.pdf"
+ end
+
+ scenario "Should update nested document file title with file name after choosing a file when no title defined", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+
+ expect(find("##{documentable_factory_name}_documents_attributes_0_title").value).to eq "empty.pdf"
+ end
+
+ scenario "Should not update nested document file title with file name after choosing a file when title already defined", :js do
+ login_as user
+ visit send(path, arguments)
+
+ click_link "Add new document"
+ sleep 1
+ fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
+ attach_file("#{documentable_factory_name}[documents_attributes][0][attachment]", "spec/fixtures/files/empty.pdf", make_visible: true)
+ sleep 1
+
+ expect(find("##{documentable_factory_name}_documents_attributes_0_title").value).to eq "Title"
+ end
+
+ scenario "Should update loading bar style after valid file upload", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+ fill_in "#{documentable_factory_name}[documents_attributes][0][title]", with: "Title"
+
+ expect(page).to have_selector ".loading-bar.complete"
+ end
+
+ scenario "Should update loading bar style after unvalid file upload", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/logo_header.png")
+
+ expect(page).to have_selector ".loading-bar.errors"
+ end
+
+ scenario "Should update document cached_attachment field after valid file upload", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+
+ expect(find("input[name='#{documentable_factory_name}[documents_attributes][0][cached_attachment]']", visible: false).value).to include("empty.pdf")
+ end
+
+ scenario "Should not update document cached_attachment field after unvalid file upload", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/logo_header.png")
+
+ expect(find("input[name='#{documentable_factory_name}[documents_attributes][0][cached_attachment]']", visible: false).value).to eq ""
+ end
+
+ scenario "Should show document errors after unvalid file upload", :js do
+ login_as user
+ visit send(path, arguments)
+
+ click_link "Add new document"
+ sleep 1
+ click_on submit_button
+
+ within "#document_0" do
+ expect(page).to have_content("can't be blank", count: 2)
+ end
+ end
+
+ scenario "Should delete document after valid file upload and click on remove button", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+ within "#document_0" do
+ click_link "Remove document"
+ end
+
+ expect(page).not_to have_selector("#document_0")
+ end
+
+ scenario "Should delete document after valid file upload and click on remove button", :js do
+ login_as user
+ visit send(path, arguments)
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+ within "#document_0" do
+ click_link "Remove document"
+ end
+
+ expect(page).to have_content "Document was deleted successfully."
+ end
+
+ scenario "Should show successful notice when resource filled correctly without any nested documents", :js do
+ login_as user
+ visit send(path, arguments)
+ send(fill_resource_method_name) if fill_resource_method_name
+
+ click_on submit_button
+ expect(page).to have_content documentable_success_notice
+ end
+
+ scenario "Should show successful notice when resource filled correctly and after valid file uploads", :js do
+ login_as user
+ visit send(path, arguments)
+ send(fill_resource_method_name) if fill_resource_method_name
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+
+ click_on submit_button
+ expect(page).to have_content documentable_success_notice
+ end
+
+ scenario "Should show new document after successful creation with one uploaded file", :js do
+ login_as user
+ visit send(path, arguments)
+ send(fill_resource_method_name) if fill_resource_method_name
+
+ attach_new_file(documentable_factory_name, 0, "spec/fixtures/files/empty.pdf")
+
+ click_on submit_button
+ redirected_to_resource_show_or_navigate_to
+
+ expect(page).to have_content "Documents (1)"
+ end
+
+ scenario "Should show resource with new document after successful creation with maximum allowed uploaded files", :js do
+ login_as user
+ visit send(path, arguments)
+ send(fill_resource_method_name) if fill_resource_method_name
+
+ documentable.class.max_documents_allowed.times.each do |index|
+ attach_new_file(documentable_factory_name, index , "spec/fixtures/files/empty.pdf")
+ end
+
+ click_on submit_button
+ redirected_to_resource_show_or_navigate_to
+
+ expect(page).to have_content "Documents (#{documentable.class.max_documents_allowed})"
+ end
+
+ end
+
+end
+
+def redirected_to_resource_show_or_navigate_to
+ find("a", text: "Not now, go to my proposal")
+ click_on "Not now, go to my proposal"
+rescue
+ return
+end
+
+def attach_new_file(documentable_factory_name, index, path)
+ click_link "Add new document"
+ sleep 1
+ attach_file("#{documentable_factory_name}[documents_attributes][#{index}][attachment]", path, make_visible: true)
+ sleep 1
+end
+
+def fill_new_valid_proposal
+ fill_in :proposal_title, with: "Proposal title"
+ fill_in :proposal_summary, with: "Proposal summary"
+ fill_in :proposal_question, with: "Proposal question?"
+ check :proposal_terms_of_service
+end
+
+def fill_new_valid_budget_investment
+ page.select documentable.heading.name_scoped_by_group, from: :budget_investment_heading_id
+ fill_in :budget_investment_title, with: "Budget investment title"
+ fill_in_ckeditor "budget_investment_description", with: "Budget investment description"
+ check :budget_investment_terms_of_service
+end
+
diff --git a/spec/shared/models/document_validations.rb b/spec/shared/models/document_validations.rb
new file mode 100644
index 000000000..3226129a3
--- /dev/null
+++ b/spec/shared/models/document_validations.rb
@@ -0,0 +1,62 @@
+shared_examples "document validations" do |documentable_factory|
+ include DocumentsHelper
+ include DocumentablesHelper
+
+ let!(:document) { build(:document, documentable_factory.to_sym) }
+ let!(:documentable) { document.documentable }
+ let!(:maxfilesize) { max_file_size(document.documentable) }
+ let!(:acceptedcontenttypes) { accepted_content_types(document.documentable) }
+
+ it "should be valid" do
+ expect(document).to be_valid
+ end
+
+ it "should not be valid without a title" do
+ document.title = nil
+
+ expect(document).to_not be_valid
+ end
+
+ it "should not be valid without an attachment" do
+ document.attachment = nil
+
+ expect(document).to_not be_valid
+ end
+
+ it "should be valid for all accepted content types" do
+ acceptedcontenttypes.each do |content_type|
+ extension = content_type.split("/").last
+ document.attachment = File.new("spec/fixtures/files/empty.#{extension}")
+
+ expect(document).to be_valid
+ end
+ end
+
+ it "should not be valid for attachments larger than documentable max_file_size definition" do
+ document.stub(:attachment_file_size).and_return(maxfilesize.megabytes + 1.byte)
+
+ expect(document).to_not be_valid
+ expect(document.errors[:attachment]).to include "must be in between 0 Bytes and #{maxfilesize} MB"
+ end
+
+ it "should not be valid without a user_id" do
+ document.user_id = nil
+
+ expect(document).to_not be_valid
+ end
+
+ it "should not be valid without a documentable_id" do
+ document.save
+ document.documentable_id = nil
+
+ expect(document).to_not be_valid
+ end
+
+ it "should not be valid without a documentable_type" do
+ document.save
+ document.documentable_type = nil
+
+ expect(document).to_not be_valid
+ end
+
+end
\ No newline at end of file