Check for attribute values in current budget tests

Assigning a variable to each budget we declare results in useless
assignments. We could just delete the three useless assignments and
leave the fourth one, but I find the code easier to read if we use the
name of the budgets to differenciate between them. This way we also keep
the code vertically aligned.

spec/controllers/application_controller_spec.rb

@@ -5,13 +5,13 @@ describe ApplicationController do
   describe "#current_budget" do
 
     it "returns the last budget that is not in draft phase" do
-      old_budget      = create(:budget, :finished,  created_at: 2.years.ago)
+      create(:budget, :finished,  created_at: 2.years.ago, name: "Old")
-      previous_budget = create(:budget, :accepting, created_at: 1.year.ago)
+      create(:budget, :accepting, created_at: 1.year.ago,  name: "Previous")
-      current_budget  = create(:budget, :accepting, created_at: 1.month.ago)
+      create(:budget, :accepting, created_at: 1.month.ago, name: "Current")
-      next_budget     = create(:budget, :drafting,  created_at: 1.week.ago)
+      create(:budget, :drafting,  created_at: 1.week.ago,  name: "Next")
 
       budget = subject.instance_eval { current_budget }
-      expect(budget).to eq(current_budget)
+      expect(budget.name).to eq("Current")
     end
 
   end

spec/models/budget_spec.rb

@@ -166,12 +166,12 @@ describe Budget do
     end
 
     it "returns the last budget created that is not in drafting phase" do
-      old_budget      = create(:budget, :finished,  created_at: 2.years.ago)
+      create(:budget, :finished,  created_at: 2.years.ago, name: "Old")
-      previous_budget = create(:budget, :accepting, created_at: 1.year.ago)
+      create(:budget, :accepting, created_at: 1.year.ago,  name: "Previous")
-      current_budget  = create(:budget, :accepting, created_at: 1.month.ago)
+      create(:budget, :accepting, created_at: 1.month.ago, name: "Current")
-      next_budget     = create(:budget, :drafting,  created_at: 1.week.ago)
+      create(:budget, :drafting,  created_at: 1.week.ago,  name: "Next")
 
-      expect(Budget.current).to eq(current_budget)
+      expect(Budget.current.name).to eq "Current"
     end
 
   end