consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify advanced filter params initialization

Browse Source
This commit is contained in:
Javi Martín
2024-10-11 23:30:59 +02:00
parent c28ff49f10
commit bc4fd63950
2 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/components/admin/budget_investments/search_form_component.html.erb
View File

@@ -1,4 +1,3 @@
<% init_advanced_menu %>
<%= form_tag(admin_budget_budget_investments_path(budget), method: :get, enforce_utf8: false, class: "admin-budget-investments-search-form") do %>
<div class="small-12 column">
<%= link_to "#advanced_filters_content",
@@ -14,7 +13,7 @@
<% %w[feasible selected undecided unfeasible without_admin without_valuator under_valuation
valuation_finished winners].each do |filter| %>
<div class="filter">
<%= check_box_tag "advanced_filters[]", filter, params[:advanced_filters].index(filter), id: "advanced_filters_#{filter}" %>
<%= check_box_tag "advanced_filters[]", filter, advanced_filters_params.index(filter), id: "advanced_filters_#{filter}" %>
<%= label_tag "advanced_filters[#{filter}]", t("admin.budget_investments.index.filters.#{filter}") %>
</div>
<% end %>

6
app/components/admin/budget_investments/search_form_component.rb
View File

@@ -8,12 +8,12 @@ class Admin::BudgetInvestments::SearchFormComponent < ApplicationComponent
private
def init_advanced_menu
params[:advanced_filters] = [] unless params[:advanced_filters]
def advanced_filters_params
params[:advanced_filters] ||= []
end
def advanced_menu_visibility
if params[:advanced_filters].empty? &&
if advanced_filters_params.empty? &&
params["min_total_supports"].blank? &&
params["max_total_supports"].blank?
"hide"