From 8f1739cc6ab22b9f49a8b89ce8e75bbfce79df23 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 8 Apr 2024 21:09:35 +0200 Subject: [PATCH 1/2] Use Stylelint instead of SCSS Lint in Code Climate We forgot to do so in commit e210682ac. --- .codeclimate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index bbc3f989e..b722dd80a 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -14,7 +14,7 @@ engines: enabled: true coffeelint: enabled: true - scss-lint: + stylelint: enabled: true fixme: enabled: true From 8d4d1b7e4bb61054a132d291188777c2f7a10c26 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 2 Jul 2024 18:40:38 +0200 Subject: [PATCH 2/2] Don't run linters in Code Climate We're now running the linters in github actions, and code climate doesn't use the same versions of the gems or npm packages that we're using in the application. For example, only a few limited rubocop versions are available, and sometimes code climate breaks because our rubocop version isn't compatible with theirs. Now we're also using a version of stylelint they don't support. All in all, the linters check in code climate isn't helpful at all anymmore. --- .codeclimate.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.codeclimate.yml b/.codeclimate.yml index b722dd80a..9b5db8e4d 100644 --- a/.codeclimate.yml +++ b/.codeclimate.yml @@ -1,7 +1,4 @@ engines: - rubocop: - enabled: true - channel: rubocop-1-56-3 duplication: enabled: true config: @@ -12,14 +9,8 @@ engines: enabled: true bundler-audit: enabled: true - coffeelint: - enabled: true - stylelint: - enabled: true fixme: enabled: true - markdownlint: - enabled: true ratings: paths: - app/**/*