From baec41c43d739724c290b5c0fdf4105a37c0994c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 14 Jun 2024 17:55:27 +0200 Subject: [PATCH] Fix screenshots in GitHub Action when two jobs fail The upload-artifact action does not support using the same artifact name in different jobs (or in different matrix scenarios) since version 4, which we started using in commit acfaada82. That meant that screenshots were not uploaded correctly when two or more knapsack nodes failed. --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 42eed46cb..dfb173e4a 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -71,7 +71,7 @@ jobs: if: failure() uses: actions/upload-artifact@v4 with: - name: screenshots + name: screenshots-${{ matrix.ci_node_index }} path: tmp/capybara/ coveralls: permissions: