From baaf9cac935a28c87744b9942ca7c0099588cee7 Mon Sep 17 00:00:00 2001
From: rgarcia <voodoorai2000@gmail.com>
Date: Mon, 27 Jul 2015 22:50:38 +0200
Subject: [PATCH] refactors duplicate form id scenario [#21]

---
 app/assets/javascripts/comments.js.coffee | 7 +++----
 app/views/comments/_form.html.erb         | 4 ++--
 spec/features/comments_spec.rb            | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/app/assets/javascripts/comments.js.coffee b/app/assets/javascripts/comments.js.coffee
index 72f0fd52f..b40da3485 100644
--- a/app/assets/javascripts/comments.js.coffee
+++ b/app/assets/javascripts/comments.js.coffee
@@ -1,13 +1,12 @@
 jQuery ->
 
-  toggle_comment = (id, klass) ->
-    $("#js-comment-form-#{id}-#{klass}").toggle()
+  toggle_comment = (id) ->
+    $("#js-comment-form-#{id}").toggle()
 
   ready = ->
     $('.js-add-comment-link').click ->
       id = $(this).data().id
-      klass = $(this).data().klass
-      toggle_comment(id, klass)
+      toggle_comment(id)
       false
 
   $(document).ready(ready)
diff --git a/app/views/comments/_form.html.erb b/app/views/comments/_form.html.erb
index 5593f7a39..e3f796026 100644
--- a/app/views/comments/_form.html.erb
+++ b/app/views/comments/_form.html.erb
@@ -1,6 +1,6 @@
-<%= link_to comment_link_text(parent), "", class: "js-add-comment-link", data: {'id': parent.id, 'klass': parent.class.to_s } %>
+<%= link_to comment_link_text(parent), "", class: "js-add-comment-link", data: {'id': dom_id(parent)} %>
 
-<div id="js-comment-form-<%= parent.id %>-<%= parent.class.to_s %>" style="display:none">
+<div id="js-comment-form-<%= dom_id(parent) %>" style="display:none">
   <%= form_for [@debate, Comment.new] do |f| %>
     <%= f.text_area :body %>
     <%= f.hidden_field :commentable_type, value: parent.class %>
diff --git a/spec/features/comments_spec.rb b/spec/features/comments_spec.rb
index b93f66090..31c07770c 100644
--- a/spec/features/comments_spec.rb
+++ b/spec/features/comments_spec.rb
@@ -48,7 +48,7 @@ feature 'Comments' do
     visit debate_path(debate)
 
     click_link "Responder"
-    within "#js-comment-form-#{comment.id}-Comment" do
+    within "#js-comment-form-comment_#{comment.id}" do
       fill_in 'comment_body', with: 'La semana que viene está hecho.'
       click_button 'Publicar respuesta'
     end