diff --git a/.rubocop.yml b/.rubocop.yml index eb4d90c04..e9772f8a8 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -41,6 +41,9 @@ FactoryBot/FactoryAssociationWithStrategy: FactoryBot/FactoryClassName: Enabled: true +FactoryBot/RedundantFactoryOption: + Enabled: true + Layout/ArgumentAlignment: Enabled: true diff --git a/spec/factories/administration.rb b/spec/factories/administration.rb index a8da8a3ed..20e99b5a8 100644 --- a/spec/factories/administration.rb +++ b/spec/factories/administration.rb @@ -41,7 +41,7 @@ FactoryBot.define do factory :banner_section, class: "Banner::Section" do association :banner_id, factory: :banner - association :web_section, factory: :web_section + association :web_section end factory :site_customization_page, class: "SiteCustomization::Page" do diff --git a/spec/factories/budgets.rb b/spec/factories/budgets.rb index 57beb8737..68bb26e8b 100644 --- a/spec/factories/budgets.rb +++ b/spec/factories/budgets.rb @@ -251,7 +251,7 @@ FactoryBot.define do end factory :budget_ballot, class: "Budget::Ballot" do - association :user, factory: :user + association :user budget transient { investments { [] } } diff --git a/spec/factories/debates.rb b/spec/factories/debates.rb index 972819059..8484b95b9 100644 --- a/spec/factories/debates.rb +++ b/spec/factories/debates.rb @@ -47,6 +47,6 @@ FactoryBot.define do factory :flag do association :flaggable, factory: :debate - association :user, factory: :user + association :user end end diff --git a/spec/factories/files.rb b/spec/factories/files.rb index 5aa2a9295..04e84d1c8 100644 --- a/spec/factories/files.rb +++ b/spec/factories/files.rb @@ -2,7 +2,7 @@ FactoryBot.define do factory :image do attachment { Rack::Test::UploadedFile.new("spec/fixtures/files/clippy.jpg") } title { "Lorem ipsum dolor sit amet" } - association :user, factory: :user + association :user trait :proposal_image do association :imageable, factory: :proposal @@ -19,7 +19,7 @@ FactoryBot.define do factory :document do sequence(:title) { |n| "Document title #{n}" } - association :user, factory: :user + association :user attachment { Rack::Test::UploadedFile.new("spec/fixtures/files/empty.pdf") } trait :proposal_document do diff --git a/spec/factories/machine_learning.rb b/spec/factories/machine_learning.rb index 98e77984e..97f6de434 100644 --- a/spec/factories/machine_learning.rb +++ b/spec/factories/machine_learning.rb @@ -1,6 +1,6 @@ FactoryBot.define do factory :machine_learning_job do - association :user, factory: :user + association :user script { "script.py" } started_at { Time.current } finished_at { nil } diff --git a/spec/factories/users.rb b/spec/factories/users.rb index 66e5e716b..7f72aba71 100644 --- a/spec/factories/users.rb +++ b/spec/factories/users.rb @@ -126,7 +126,7 @@ FactoryBot.define do end factory :follow do - association :user, factory: :user + association :user trait :followed_proposal do association :followable, factory: :proposal