Move budget actions out of the form

Since we aren't very consistent in the styles for submit buttons in the
admin section, it was possible to accidentally press the "Calculate
Winner Investments" link after filling in the form. This wouldn't submit
the form and so the changes wouldn't be saved.

It's also a bit confusing for users. After filling in a form, users
expect a submit button. When finding two buttons, they've got to stop to
think which one is the one they've got to press.

Furthermore, the "Calculate Winner Investments" link would work better
as a button instead of a link, for the reasons mentioned in commit
5311daadf. Since HTML forms can't be nested, that would mean treating
this button in a different way than the rest of the buttons in the
application.

Moving the link before the form solves the issue.

Since now we've got the budget actions before the budget form, we're
grouping these actions together with the "Preview" action. We're not
adding the "Publish budget" button as well to this group because it's
got an associated message.

app/assets/stylesheets/admin/budgets/actions.scss

@@ -0,0 +1,27 @@
+.admin .budgets-actions {
+  $gap: $line-height;
+  @include flex-with-gap($gap);
+  align-items: baseline;
+  flex-wrap: wrap;
+  margin-top: -$gap;
+
+  > * {
+    margin-bottom: 0;
+    margin-top: $gap;
+  }
+
+  + * {
+    margin-top: $line-height;
+  }
+
+  .preview-link {
+    @include has-fa-icon(eye, regular);
+    @include hollow-button;
+    margin-left: $gap;
+    margin-top: $gap;
+
+    &::before {
+      margin-#{$global-right}: $font-icon-margin;
+    }
+  }
+}

app/assets/stylesheets/admin/budgets/drafting.scss

@@ -1,41 +1,25 @@
 .admin .drafting {
-  margin-bottom: 2 * $line-height / 3;
+  $vertical-gap: nth($callout-margin, 3);
-  margin-left: auto;
+  @include flex-with-gap($line-height / 2);
+  align-items: flex-start;
+  flex-wrap: wrap;
+  margin-bottom: $line-height * 1.5;
+  margin-top: -$vertical-gap;
 
-  @include breakpoint(large) {
+  > * {
-    align-items: flex-start;
+    margin-top: $vertical-gap;
-    display: flex;
-
-    .callout {
-      flex: 1;
-      margin-bottom: 0;
-    }
   }
 
-  @include breakpoint(small medium only) {
+  .callout {
-    text-align: right;
+    flex-basis: $global-width / 3;
-
+    flex-grow: 1;
-    .callout {
+    margin-bottom: 0;
-      text-align: left;
-    }
-  }
-
-  .preview-link {
-    @include has-fa-icon(eye, regular);
-    @include hollow-button;
-
-    &::before {
-      margin-right: $font-icon-margin;
-    }
   }
 
   .publish-link {
     @include regular-button;
     margin-bottom: 0;
-  }
+    margin-#{$global-left}: $line-height / 2;
-
+    margin-top: $vertical-gap;
-  .preview-link,
-  .publish-link {
-    margin-left: $line-height / 2;
   }
 }

app/components/admin/budgets/actions_component.html.erb

@@ -0,0 +1,15 @@
+<div class="budgets-actions">
+  <%= render Admin::Budgets::CalculateWinnersButtonComponent.new(budget) %>
+  <% if budget.has_winning_investments? %>
+    <%= link_to t("budgets.show.see_results"),
+                budget_results_path(budget),
+                class: "button hollow" %>
+  <% end %>
+
+  <%= link_to t("admin.budgets.actions.preview"), budget_path(budget), class: "preview-link", target: "_blank" %>
+
+  <%= link_to t("admin.budgets.edit.delete"),
+      admin_budget_path(budget),
+      method: :delete,
+      class: "delete" %>
+</div>

app/components/admin/budgets/actions_component.rb

@@ -0,0 +1,7 @@
+class Admin::Budgets::ActionsComponent < ApplicationComponent
+  attr_reader :budget
+
+  def initialize(budget)
+    @budget = budget
+  end
+end

app/components/admin/budgets/drafting_component.html.erb

@@ -1,16 +1,10 @@
 <div class="drafting">
-  <% if can? :publish, budget %>
+  <div class="callout warning">
-    <div class="callout warning">
+    <strong><%= t("admin.budgets.edit.drafting") %></strong>
-      <strong><%= t("admin.budgets.edit.drafting") %></strong>
+  </div>
-    </div>
-  <% end %>
 
-  <%= link_to t("admin.budgets.actions.preview"), budget_path(budget), class: "preview-link", target: "_blank" %>
+  <%= link_to t("admin.budgets.edit.publish"),
-
+              publish_admin_budget_path(budget),
-  <% if can? :publish, budget %>
+              method: :patch, class: "publish-link",
-    <%= link_to t("admin.budgets.edit.publish"),
+              data: { confirm: t("admin.actions.confirm") } %>
-                publish_admin_budget_path(budget),
-                method: :patch, class: "publish-link",
-                data: { confirm: t("admin.actions.confirm") } %>
-  <% end %>
 </div>

app/components/admin/budgets/drafting_component.rb

@@ -5,4 +5,8 @@ class Admin::Budgets::DraftingComponent < ApplicationComponent
   def initialize(budget)
     @budget = budget
   end
+
+  def render?
+    can?(:publish, budget)
+  end
 end

app/components/admin/budgets/form_component.html.erb

@@ -84,21 +84,5 @@
         <%= f.submit nil, class: "button success" %>
       <% end %>
     </div>
-
-    <div class="float-right">
-      <%= render Admin::Budgets::CalculateWinnersButtonComponent.new(budget) %>
-
-      <% if budget.has_winning_investments? %>
-        <%= link_to t("budgets.show.see_results"),
-                    budget_results_path(budget),
-                    class: "button hollow margin-left" %>
-      <% end %>
-      <% if budget.persisted? %>
-        <%= link_to t("admin.budgets.edit.delete"),
-            admin_budget_path(budget),
-            method: :delete,
-            class: "delete float-right margin-left" %>
-      <% end %>
-    </div>
   </div>
 <% end %>

app/views/admin/budgets/edit.html.erb

@@ -5,4 +5,5 @@
   <%= render Admin::Budgets::DraftingComponent.new(@budget) %>
 </header>
 
+<%= render Admin::Budgets::ActionsComponent.new(@budget) %>
 <%= render Admin::Budgets::FormComponent.new(@budget) %>