From 1e46746d6a4d5907983a7ffc032cfabc779acd6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sen=C3=A9n=20Rodero=20Rodr=C3=ADguez?= <15726+Senen@users.noreply.github.com> Date: Fri, 17 Nov 2023 14:02:48 +0100 Subject: [PATCH] Filter airbrake parameters As Rails does with the application log and other tools. We are going to use the same filtering rules we use in Consul Democracy. We are renaming the initializer file name `filter_parameter_logging.rb` so it's loaded before the errbit initializer. --- ...parameter_logging.rb => 01_filter_parameter_logging.rb} | 0 config/initializers/errbit.rb | 2 ++ spec/airbrake_spec.rb | 7 +++++++ 3 files changed, 9 insertions(+) rename config/initializers/{filter_parameter_logging.rb => 01_filter_parameter_logging.rb} (100%) create mode 100644 spec/airbrake_spec.rb diff --git a/config/initializers/filter_parameter_logging.rb b/config/initializers/01_filter_parameter_logging.rb similarity index 100% rename from config/initializers/filter_parameter_logging.rb rename to config/initializers/01_filter_parameter_logging.rb diff --git a/config/initializers/errbit.rb b/config/initializers/errbit.rb index 65890518a..dc45bf920 100644 --- a/config/initializers/errbit.rb +++ b/config/initializers/errbit.rb @@ -16,6 +16,8 @@ Airbrake.configure do |config| config.job_stats = false config.query_stats = false config.remote_config = false + + config.blocklist_keys = Rails.application.config.filter_parameters end Airbrake.add_filter do |notice| diff --git a/spec/airbrake_spec.rb b/spec/airbrake_spec.rb new file mode 100644 index 000000000..cd87f6917 --- /dev/null +++ b/spec/airbrake_spec.rb @@ -0,0 +1,7 @@ +require "rails_helper" + +describe "Airbrake" do + it "uses the same filtering rules that Consul Democracy" do + expect(Airbrake::Config.instance.blocklist_keys).to eq Rails.application.config.filter_parameters + end +end