consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't create an officer for poll voter factories

Browse Source 
For web poll voters, it isn't necessary in order to make the record
valid, and it adds an extra record to the database for each poll
voter created.
This commit is contained in:
Javi Martín
2019-03-15 20:46:14 +01:00
parent d69adbccb7
commit b3a8924fe0
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spec/factories/polls.rb
View File

@@ -87,7 +87,6 @@ FactoryBot.define do
factory :poll_voter, class: "Poll::Voter" do factory :poll_voter, class: "Poll::Voter" do
poll poll
association :user, :level_two association :user, :level_two
association :officer, factory: :poll_officer
from_web from_web
trait :from_web do trait :from_web do
@@ -103,7 +102,9 @@ FactoryBot.define do
end end
officer_assignment do officer_assignment do
association :poll_officer_assignment, booth_assignment: booth_assignment, officer: officer association :poll_officer_assignment,
booth_assignment: booth_assignment,
officer: officer || association(:poll_officer)
end end
end end