Add login managed user only to the specs that need it

We prepare the file to be able to include specs
that do not need to have a logged-in user.

We also took the opportunity to not execute this
line in some specs where it was not necessary.

spec/system/management/budget_investments_spec.rb

@@ -7,8 +7,6 @@ describe "Budget Investments" do
   let(:heading) { create(:budget_heading, group: group, name: "Health") }
   let(:user)    { create(:user, :level_two) }
 
-  before { login_managed_user(user) }
-
   it_behaves_like "mappable",
                   "budget_investment",
                   "investment",
@@ -22,6 +20,7 @@ describe "Budget Investments" do
     let(:investment) { create(:budget_investment, budget: budget) }
 
     scenario "finds investment using budget slug" do
+      login_managed_user(user)
       login_as_manager(manager)
       visit management_budget_investment_path("budget_slug", investment)
 
@@ -33,6 +32,7 @@ describe "Budget Investments" do
     before { heading.budget.update(phase: "accepting") }
 
     scenario "Creating budget investments on behalf of someone, selecting a budget" do
+      login_managed_user(user)
       login_as_manager(manager)
       click_link "Create budget investment"
       within "#budget_#{budget.id}" do
@@ -77,6 +77,8 @@ describe "Budget Investments" do
     end
 
     scenario "Shows suggestions to unverified managers" do
+      login_managed_user(user)
+
       expect(manager.user.level_two_or_three_verified?).to be false
 
       create(:budget_investment, budget: budget, title: "More parks")
@@ -105,6 +107,7 @@ describe "Budget Investments" do
       budget_investment1 = create(:budget_investment, budget: budget, title: "Show me what you got")
       budget_investment2 = create(:budget_investment, budget: budget, title: "Get Schwifty")
 
+      login_managed_user(user)
       login_as_manager(manager)
       click_link "Support budget investments"
       expect(page).to have_content(budget.name)
@@ -131,6 +134,7 @@ describe "Budget Investments" do
       budget_investment2 = create(:budget_investment, budget: budget, title: "Let's go",
                                                       heading: create(:budget_heading, name: "Area 52"))
 
+      login_managed_user(user)
       login_as_manager(manager)
       click_link "Support budget investments"
       expect(page).to have_content(budget.name)
@@ -156,6 +160,7 @@ describe "Budget Investments" do
     budget_investment1 = create(:budget_investment, budget: budget, title: "Show me what you got")
     budget_investment2 = create(:budget_investment, budget: budget, title: "Get Schwifty")
 
+    login_managed_user(user)
     login_as_manager(manager)
     click_link "Support budget investments"
     expect(page).to have_content(budget.name)
@@ -190,6 +195,7 @@ describe "Budget Investments" do
     reviewing_ballots_budget = create(:budget, :reviewing_ballots)
     finished = create(:budget, :finished)
 
+    login_managed_user(user)
     login_as_manager(manager)
     click_link "Create budget investment"
 
@@ -212,6 +218,7 @@ describe "Budget Investments" do
     reviewing_ballots_budget = create(:budget, :reviewing_ballots)
     finished = create(:budget, :finished)
 
+    login_managed_user(user)
     login_as(create(:administrator).user)
 
     visit management_sign_in_path
@@ -232,6 +239,7 @@ describe "Budget Investments" do
     scenario "Supporting budget investments on behalf of someone in index view" do
       budget_investment = create(:budget_investment, heading: heading)
 
+      login_managed_user(user)
       login_as_manager(manager)
       click_link "Support budget investments"
       expect(page).to have_content(budget.name)
@@ -252,6 +260,7 @@ describe "Budget Investments" do
     xscenario "Supporting budget investments on behalf of someone in show view" do
       budget_investment = create(:budget_investment, budget: budget)
 
+      login_managed_user(user)
       login_as_manager(manager)
       click_link "Support budget investments"
       expect(page).to have_content(budget.name)

spec/system/management/proposals_spec.rb

@@ -3,12 +3,9 @@ require "rails_helper"
 describe "Proposals" do
   let(:user) { create(:user, :level_two) }
 
-  before do
-    login_managed_user(user)
-  end
-
   context "Create" do
     scenario "Creating proposals on behalf of someone" do
+      login_managed_user(user)
       login_as_manager
       click_link "Create proposal"
 
@@ -54,6 +51,7 @@ describe "Proposals" do
       proposal = create(:proposal)
 
       right_path = management_proposal_path(proposal)
+      login_managed_user(user)
       login_as_manager
       visit right_path
 
@@ -66,6 +64,7 @@ describe "Proposals" do
       right_path = management_proposal_path(proposal)
       old_path = "#{management_proposals_path}/#{proposal.id}-something-else"
 
+      login_managed_user(user)
       login_as_manager
       visit old_path
 
@@ -76,6 +75,7 @@ describe "Proposals" do
     scenario "Successful proposal" do
       proposal = create(:proposal, :successful, title: "Success!")
 
+      login_managed_user(user)
       login_as_manager
       visit management_proposal_path(proposal)
 
@@ -87,6 +87,7 @@ describe "Proposals" do
     proposal1 = create(:proposal, title: "Show me what you got")
     proposal2 = create(:proposal, title: "Get Schwifty")
 
+    login_managed_user(user)
     login_as_manager
     click_link "Support proposals"
 
@@ -108,6 +109,7 @@ describe "Proposals" do
     proposal1 = create(:proposal, title: "Show me what you got")
     proposal2 = create(:proposal, title: "Get Schwifty")
 
+    login_managed_user(user)
     login_as_manager
     click_link "Support proposals"
 
@@ -133,6 +135,7 @@ describe "Proposals" do
     let!(:proposal) { create(:proposal) }
 
     scenario "Voting proposals on behalf of someone in index view" do
+      login_managed_user(user)
       login_as_manager
       click_link "Support proposals"
 
@@ -146,6 +149,7 @@ describe "Proposals" do
     end
 
     scenario "Voting proposals on behalf of someone in show view" do
+      login_managed_user(user)
       login_as_manager
       click_link "Support proposals"