Add groups step to budget creation
Note we're keeping this section's original design (which had one button to add a new group which after being pressed was replaced by a button to cancel) but we aren't using Foundation's `data-toggle` because there were a couple of usability and accessibility issues. First, using `data-toggle` multiple times and applying it to multiple elements led to the "cancel" button not being available after submitting a form with errors. Fixing it made the code more complicated. Second, the "Add new group" button always had the `aria-expanded` attribute set to "true", so my screen reader was announcing the button as expanded even when it wasn't. I didn't manage to fix it using `data-toggle`. Finally, after pressing either the "Add new group" and "Cancel" buttons, the keyboard focus was lost since the elements disappeared. So we're simplifying the HTML and adding some custom JavaScript to be able to handle the focus and manually setting the `aria-expanded` attribute. Co-Authored-By: Javi Martín <javim@elretirao.net> Co-Authored-By: Julian Herrero <microweb10@gmail.com>
This commit is contained in:
@@ -73,7 +73,9 @@ namespace :admin do
|
||||
end
|
||||
|
||||
namespace :budgets_wizard do
|
||||
resources :budgets, only: [:create, :new]
|
||||
resources :budgets, only: [:create, :new] do
|
||||
resources :groups, only: [:index, :create, :edit, :update, :destroy]
|
||||
end
|
||||
end
|
||||
|
||||
resources :milestone_statuses, only: [:index, :new, :create, :update, :edit, :destroy]
|
||||
|
||||
Reference in New Issue
Block a user