consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix public_for_api association tests

Browse Source 
These tests were always passing because they were stubbing the response
of the same method they were testing. For example, we were testing the
result of `Comment.public_for_api` and stubbing it at the same time.

So we're now stubbing the result of the associations; for example, in
order to test `Comment.public_for_api`, we're stubbing the response of
`Debate.public_for_api`. Now the tests fail if, for instance, the
implementation of `Comment.public_for_api` returns all comments.
This commit is contained in:
Javi Martín
2024-07-23 17:04:59 +02:00
parent b44d217b00
commit b1b963f90a
1 changed files with 12 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
spec/lib/graphql_spec.rb
View File

@@ -362,9 +362,8 @@ describe "Consul Schema" do
end end
it "does not include comments of debates that are not public" do it "does not include comments of debates that are not public" do
not_public_debate = create(:debate, :hidden) allow(Debate).to receive(:public_for_api).and_return([])
not_public_debate_comment = create(:comment, commentable: not_public_debate) not_public_debate_comment = create(:comment, commentable: create(:debate))
allow(Comment).to receive(:public_for_api).and_return([])
response = execute("{ comments { edges { node { body } } } }") response = execute("{ comments { edges { node { body } } } }")
received_comments = extract_fields(response, "comments", "body") received_comments = extract_fields(response, "comments", "body")
@@ -373,9 +372,8 @@ describe "Consul Schema" do
end end
it "does not include comments of proposals that are not public" do it "does not include comments of proposals that are not public" do
not_public_proposal = create(:proposal) allow(Proposal).to receive(:public_for_api).and_return([])
not_public_proposal_comment = create(:comment, commentable: not_public_proposal) not_public_proposal_comment = create(:comment, commentable: create(:proposal))
allow(Comment).to receive(:public_for_api).and_return([])
response = execute("{ comments { edges { node { body } } } }") response = execute("{ comments { edges { node { body } } } }")
received_comments = extract_fields(response, "comments", "body") received_comments = extract_fields(response, "comments", "body")
@@ -384,9 +382,8 @@ describe "Consul Schema" do
end end
it "does not include comments of polls that are not public" do it "does not include comments of polls that are not public" do
not_public_poll = create(:poll) allow(Poll).to receive(:public_for_api).and_return([])
not_public_poll_comment = create(:comment, commentable: not_public_poll) not_public_poll_comment = create(:comment, commentable: create(:poll))
allow(Comment).to receive(:public_for_api).and_return([])
response = execute("{ comments { edges { node { body } } } }") response = execute("{ comments { edges { node { body } } } }")
received_comments = extract_fields(response, "comments", "body") received_comments = extract_fields(response, "comments", "body")
@@ -462,9 +459,8 @@ describe "Consul Schema" do
end end
it "does not include proposal notifications for proposals that are not public" do it "does not include proposal notifications for proposals that are not public" do
not_public_proposal = create(:proposal) allow(Proposal).to receive(:public_for_api).and_return([])
not_public_proposal_notification = create(:proposal_notification, proposal: not_public_proposal) not_public_proposal_notification = create(:proposal_notification, proposal: create(:proposal))
allow(ProposalNotification).to receive(:public_for_api).and_return([])
response = execute("{ proposal_notifications { edges { node { title } } } }") response = execute("{ proposal_notifications { edges { node { title } } } }")
received_notifications = extract_fields(response, "proposal_notifications", "title") received_notifications = extract_fields(response, "proposal_notifications", "title")
@@ -558,8 +554,8 @@ describe "Consul Schema" do
end end
it "does not display tags for taggings that are not public" do it "does not display tags for taggings that are not public" do
allow(Proposal).to receive(:public_for_api).and_return([])
create(:proposal, tag_list: "Health") create(:proposal, tag_list: "Health")
allow(Tag).to receive(:public_for_api).and_return([])
response = execute("{ tags { edges { node { name } } } }") response = execute("{ tags { edges { node { name } } } }")
received_tags = extract_fields(response, "tags", "name") received_tags = extract_fields(response, "tags", "name")
@@ -638,7 +634,7 @@ describe "Consul Schema" do
end end
it "does not include votes of debates that are not public" do it "does not include votes of debates that are not public" do
allow(Vote).to receive(:public_for_api).and_return([]) allow(Debate).to receive(:public_for_api).and_return([])
not_public_debate = create(:debate, voters: [create(:user)]) not_public_debate = create(:debate, voters: [create(:user)])
response = execute("{ votes { edges { node { votable_id } } } }") response = execute("{ votes { edges { node { votable_id } } } }")
@@ -648,7 +644,7 @@ describe "Consul Schema" do
end end
it "does not include votes of a hidden proposals" do it "does not include votes of a hidden proposals" do
allow(Vote).to receive(:public_for_api).and_return([]) allow(Proposal).to receive(:public_for_api).and_return([])
not_public_proposal = create(:proposal, voters: [create(:user)]) not_public_proposal = create(:proposal, voters: [create(:user)])
response = execute("{ votes { edges { node { votable_id } } } }") response = execute("{ votes { edges { node { votable_id } } } }")
@@ -658,7 +654,7 @@ describe "Consul Schema" do
end end
it "does not include votes of a hidden comments" do it "does not include votes of a hidden comments" do
allow(Vote).to receive(:public_for_api).and_return([]) allow(Comment).to receive(:public_for_api).and_return([])
not_public_comment = create(:comment, voters: [create(:user)]) not_public_comment = create(:comment, voters: [create(:user)])
response = execute("{ votes { edges { node { votable_id } } } }") response = execute("{ votes { edges { node { votable_id } } } }")