consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use a button to toggle proposal selection

Browse Source 
As mentioned in commit 5311daadf, using buttons for non-GET requests has
several advantages over using links.
This commit is contained in:
Javi Martín
2021-08-20 02:33:05 +02:00
parent 43b6ab00e3
commit b127bd2f51
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/components/admin/proposals/toggle_selection_component.html.erb
View File

@@ -1 +1 @@
<%= link_to text, path, options %> <%= button_to text, path, options %>

2
spec/system/admin/legislation/proposals_spec.rb
View File

@@ -19,7 +19,7 @@ describe "Admin collaborative legislation", :admin do
proposal = create(:legislation_proposal, cached_votes_score: 10) proposal = create(:legislation_proposal, cached_votes_score: 10)
visit admin_legislation_process_proposals_path(proposal.legislation_process_id) visit admin_legislation_process_proposals_path(proposal.legislation_process_id)
click_link "Select" click_button "Select"
within "#legislation_proposal_#{proposal.id}" do within "#legislation_proposal_#{proposal.id}" do
expect(page).to have_content("Selected") expect(page).to have_content("Selected")

12
spec/system/admin/proposals_spec.rb
View File

@@ -26,13 +26,13 @@ describe "Admin proposals", :admin do
visit admin_proposals_path visit admin_proposals_path
within("#proposal_#{proposal.id}") { click_link "Select" } within("#proposal_#{proposal.id}") { click_button "Select" }
within("#proposal_#{proposal.id}") { expect(page).to have_link "Selected" } within("#proposal_#{proposal.id}") { expect(page).to have_button "Selected" }
refresh refresh
within("#proposal_#{proposal.id}") { expect(page).to have_link "Selected" } within("#proposal_#{proposal.id}") { expect(page).to have_button "Selected" }
end end
scenario "Unselect a proposal" do scenario "Unselect a proposal" do
@@ -40,13 +40,13 @@ describe "Admin proposals", :admin do
visit admin_proposals_path visit admin_proposals_path
within("#proposal_#{proposal.id}") { click_link "Selected" } within("#proposal_#{proposal.id}") { click_button "Selected" }
within("#proposal_#{proposal.id}") { expect(page).to have_link "Select" } within("#proposal_#{proposal.id}") { expect(page).to have_button "Select" }
refresh refresh
within("#proposal_#{proposal.id}") { expect(page).to have_link "Select" } within("#proposal_#{proposal.id}") { expect(page).to have_button "Select" }
end end
end end