Simplify poll voter factory associations

2019-01-11 20:23:46 +01:00
parent d83bf940be
commit b05ea2964c
1 changed files with 4 additions and 5 deletions
--- a/spec/factories/polls.rb
+++ b/spec/factories/polls.rb
@@ -91,12 +91,11 @@ FactoryBot.define do
    origin "web"

    trait :from_booth do
-      association :booth_assignment, factory: :poll_booth_assignment
      origin "booth"
-      before :create do |voter|
-        voter.officer_assignment = create(:poll_officer_assignment,
-                                          officer: voter.officer,
-                                          booth_assignment: voter.booth_assignment)
+      association :booth_assignment, factory: :poll_booth_assignment
+
+      officer_assignment do
+        association :poll_officer_assignment, booth_assignment: booth_assignment, officer: officer
      end
    end