From ae98dbf683d3d24f4156f49bdc7639e013813aeb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 7 Aug 2019 13:43:57 +0200 Subject: [PATCH] Use Rails 5.1 conventions in tests params --- .rubocop.yml | 3 --- .rubocop_basic.yml | 3 +++ spec/controllers/debates_controller_spec.rb | 2 +- spec/controllers/remote_translation_controller_spec.rb | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 6936f6f78..5854c404b 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -138,9 +138,6 @@ Rails/HasAndBelongsToMany: Rails/HasManyOrHasOneDependent: Enabled: true -Rails/HttpPositionalArguments: - Enabled: true - Rails/InverseOf: Enabled: true diff --git a/.rubocop_basic.yml b/.rubocop_basic.yml index cd71adb58..1d9d41b45 100644 --- a/.rubocop_basic.yml +++ b/.rubocop_basic.yml @@ -53,6 +53,9 @@ Rails/ApplicationJob: Rails/ApplicationRecord: Enabled: true +Rails/HttpPositionalArguments: + Enabled: true + RSpec/NotToNot: Enabled: true diff --git a/spec/controllers/debates_controller_spec.rb b/spec/controllers/debates_controller_spec.rb index 2e8b111d2..67f98936e 100644 --- a/spec/controllers/debates_controller_spec.rb +++ b/spec/controllers/debates_controller_spec.rb @@ -24,7 +24,7 @@ describe DebatesController do } sign_in create(:user) - post :create, debate: debate_attributes + post :create, params: { debate: debate_attributes } expect(Ahoy::Event.where(name: :debate_created).count).to eq 1 expect(Ahoy::Event.last.properties["debate_id"]).to eq Debate.last.id end diff --git a/spec/controllers/remote_translation_controller_spec.rb b/spec/controllers/remote_translation_controller_spec.rb index f38a4aedf..fec828b55 100644 --- a/spec/controllers/remote_translation_controller_spec.rb +++ b/spec/controllers/remote_translation_controller_spec.rb @@ -18,7 +18,7 @@ describe RemoteTranslationsController do end it "create correctly remote translation" do - post :create, remote_translations: @remote_translations_params + post :create, params: { remote_translations: @remote_translations_params } expect(RemoteTranslation.count).to eq(1) end @@ -26,7 +26,7 @@ describe RemoteTranslationsController do it "create remote translation when same remote translation with error_message is enqueued" do create(:remote_translation, remote_translatable: debate, locale: :es, error_message: "Has errors") - post :create, remote_translations: @remote_translations_params + post :create, params: { remote_translations: @remote_translations_params } expect(RemoteTranslation.count).to eq(2) end @@ -34,13 +34,13 @@ describe RemoteTranslationsController do it "not create remote translation when same remote translation is enqueued" do create(:remote_translation, remote_translatable: debate, locale: :es) - post :create, remote_translations: @remote_translations_params + post :create, params: { remote_translations: @remote_translations_params } expect(RemoteTranslation.count).to eq(1) end it "redirect_to request referer after create" do - post :create, remote_translations: @remote_translations_params + post :create, params: { remote_translations: @remote_translations_params } expect(subject).to redirect_to("any_path") end