consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #4683 from consul/empty_sdg_tags

Browse Source 
Don't render empty SDG tag list div
This commit is contained in:
Javi Martín
2021-10-04 16:07:28 +02:00
committed by GitHub
parent 3a84defce3 391d1083e4
commit adaa9c021f
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/components/sdg/tag_list_component.rb
View File

@@ -7,6 +7,10 @@ class SDG::TagListComponent < ApplicationComponent
@linkable = linkable @linkable = linkable
end end
def render?
record.sdg_goals.any? || record.sdg_targets.any?
end
private private
def goals_list def goals_list

8
spec/components/sdg/tag_list_component_spec.rb
View File

@@ -22,6 +22,14 @@ describe SDG::TagListComponent do
expect(page).to have_link "target 3.2.1" expect(page).to have_link "target 3.2.1"
end end
it "does not render when there are no tags" do
record = build(:debate, sdg_goals: [], sdg_targets: [])
render_inline SDG::TagListComponent.new(record)
expect(page.native.inner_html).to be_empty
end
context "when linkable is false" do context "when linkable is false" do
let(:component) { SDG::TagListComponent.new(debate, linkable: false) } let(:component) { SDG::TagListComponent.new(debate, linkable: false) }