Undo user.moderator? returning true for admins
This commit is contained in:
@@ -5,7 +5,7 @@ class Moderation::BaseController < ApplicationController
|
||||
private
|
||||
|
||||
def verify_moderator
|
||||
raise CanCan::AccessDenied unless current_user.try(:moderator?)
|
||||
raise CanCan::AccessDenied unless current_user.try(:moderator?) || current_user.try(:administrator?)
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
@@ -25,6 +25,6 @@ class User < ActiveRecord::Base
|
||||
end
|
||||
|
||||
def moderator?
|
||||
@is_moderator ||= Moderator.where(user_id: id).exists? || administrator?
|
||||
@is_moderator ||= Moderator.where(user_id: id).exists?
|
||||
end
|
||||
end
|
||||
|
||||
@@ -100,7 +100,7 @@ describe User do
|
||||
end
|
||||
|
||||
describe "moderator?" do
|
||||
it "is false when the user is not a moderator nor an administrator" do
|
||||
it "is false when the user is not a moderator" do
|
||||
expect(subject.moderator?).to be false
|
||||
end
|
||||
|
||||
@@ -109,12 +109,6 @@ describe User do
|
||||
create(:moderator, user: subject)
|
||||
expect(subject.moderator?).to be true
|
||||
end
|
||||
|
||||
it "is true when the user is an administrator" do
|
||||
subject.save
|
||||
create(:administrator, user: subject)
|
||||
expect(subject.moderator?).to be true
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user