Test restoring data from the user's point of view

We were checking the database, but users don't care about what's inside
the database; they care about what happens when they visit the page of a
record they've just restored.

This way we also avoid data inconsistency due to the process running the
test accessing the database after the process running the browser has
started.

spec/system/admin/hidden_budget_investments_spec.rb

@@ -22,9 +22,9 @@ describe "Admin hidden budget investments", :admin do
 
     expect(page).not_to have_content(investment.title)
 
-    investment.reload
+    visit budget_investment_path(investment.budget, investment)
 
-    expect(investment).to be_ignored_flag
+    expect(page).to have_content(investment.title)
   end
 
   scenario "Confirm hide" do

spec/system/admin/hidden_comments_spec.rb

@@ -71,8 +71,9 @@ describe "Admin hidden comments", :admin do
 
     expect(page).not_to have_content(comment.body)
 
-    expect(comment.reload).not_to be_hidden
+    visit comment_path(comment)
-    expect(comment).to be_ignored_flag
+
+    expect(page).to have_content(comment.body)
   end
 
   scenario "Confirm hide" do

spec/system/admin/hidden_debates_spec.rb

@@ -9,8 +9,9 @@ describe "Admin hidden debates", :admin do
 
     expect(page).not_to have_content(debate.title)
 
-    expect(debate.reload).not_to be_hidden
+    visit debate_path(debate)
-    expect(debate).to be_ignored_flag
+
+    expect(page).to have_content debate.title
   end
 
   scenario "Confirm hide" do

spec/system/admin/hidden_proposals_spec.rb

@@ -22,8 +22,9 @@ describe "Admin hidden proposals", :admin do
 
     expect(page).not_to have_content(proposal.title)
 
-    expect(proposal.reload).not_to be_hidden
+    visit proposal_path(proposal)
-    expect(proposal).to be_ignored_flag
+
+    expect(page).to have_content proposal.title
   end
 
   scenario "Confirm hide" do

spec/system/admin/hidden_users_spec.rb

@@ -25,7 +25,9 @@ describe "Admin hidden users", :admin do
 
     expect(page).not_to have_content(user.username)
 
-    expect(user.reload).not_to be_hidden
+    visit user_path(user)
+
+    expect(page).to have_content(user.username)
   end
 
   scenario "Confirm hide" do

spec/system/admin/proposal_notifications_spec.rb

@@ -17,9 +17,11 @@ describe "Admin proposal notifications", :admin do
 
     expect(page).not_to have_content(proposal_notification.title)
 
-    expect(proposal_notification.reload).not_to be_hidden
+    logout
-    expect(proposal_notification).to be_ignored
+    login_as(proposal_notification.author)
-    expect(proposal_notification).not_to be_moderated
+    visit proposal_notification_path(proposal_notification)
+
+    expect(page).to have_content(proposal_notification.title)
   end
 
   scenario "Confirm hide" do