From a56f1c75d619741e7d05fde0469305e14bb3e456 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baza=CC=81n?= <jjbazan@gmail.com>
Date: Thu, 8 Dec 2016 11:25:50 +0100
Subject: [PATCH] changes name to helper methods to signal boolean return

---
 app/helpers/admin_helper.rb    | 12 ++++++------
 app/views/admin/_menu.html.erb | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/app/helpers/admin_helper.rb b/app/helpers/admin_helper.rb
index 6c6bfbe25..ec99c240b 100644
--- a/app/helpers/admin_helper.rb
+++ b/app/helpers/admin_helper.rb
@@ -4,27 +4,27 @@ module AdminHelper
     render "/#{namespace}/menu"
   end
 
-  def menu_tags
+  def menu_tags?
     ["tags"].include? controller_name
   end
 
-  def menu_moderated_content
+  def menu_moderated_content?
     ["proposals", "debates", "comments", "users"].include? controller_name
   end
 
-  def menu_budget
+  def menu_budget?
     ["spending_proposals"].include? controller_name
   end
 
-  def menu_polls
+  def menu_polls?
     ["polls", "questions", "officers", "booths"].include? controller_name
   end
 
-  def menu_profiles
+  def menu_profiles?
     ["organizations", "officials", "moderators", "valuators", "managers"].include? controller_name
   end
 
-  def menu_banners
+  def menu_banners?
     ["banners"].include? controller_name
   end
 
diff --git a/app/views/admin/_menu.html.erb b/app/views/admin/_menu.html.erb
index 45608b5ee..f7b0a2ac5 100644
--- a/app/views/admin/_menu.html.erb
+++ b/app/views/admin/_menu.html.erb
@@ -6,7 +6,7 @@
         <span class="icon-proposals"></span>
         <strong><%= t("admin.menu.title_categories") %></strong>
       </a>
-      <ul <%= "class=is-active" if menu_tags %>>
+      <ul <%= "class=is-active" if menu_tags? %>>
         <li <%= "class=active" if controller_name == "tags" %>>
           <%= link_to t("admin.menu.proposals_topics"), admin_tags_path %>
         </li>
@@ -18,7 +18,7 @@
         <span class="icon-eye"></span>
         <strong><%= t("admin.menu.title_moderated_content") %></strong>
       </a>
-      <ul <%= "class=is-active" if menu_moderated_content %>>
+      <ul <%= "class=is-active" if menu_moderated_content? %>>
         <li <%= "class=active" if controller_name == "proposals" %>>
           <%= link_to t("admin.menu.hidden_proposals"), admin_proposals_path %>
         </li>
@@ -45,7 +45,7 @@
           <span class="icon-budget"></span>
           <strong><%= t("admin.menu.title_budgets") %></strong>
         </a>
-        <ul <%= "class=is-active" if menu_budget %>>
+        <ul <%= "class=is-active" if menu_budget? %>>
           <li <%= "class=active" if controller_name == "spending_proposals" %>>
             <%= link_to t("admin.menu.spending_proposals"), admin_spending_proposals_path %>
           </li>
@@ -59,7 +59,7 @@
           <span class="icon-checkmark-circle"></span>
           <strong><%= t("admin.menu.title_polls") %></strong>
         </a>
-        <ul id="polls_menu" <%= "class=is-active" if menu_polls %>>
+        <ul id="polls_menu" <%= "class=is-active" if menu_polls? %>>
           <li <%= 'class=active' if controller_name == 'polls' %>>
             <%= link_to t('admin.menu.polls'), admin_polls_path %>
           </li>
@@ -84,7 +84,7 @@
         <span class="icon-organizations"></span>
         <strong><%= t("admin.menu.title_profiles") %></strong>
       </a>
-      <ul <%= "class=is-active" if menu_profiles %>>
+      <ul <%= "class=is-active" if menu_profiles? %>>
         <li <%= "class=active" if controller_name == "organizations" %>>
           <%= link_to t("admin.menu.organizations"), admin_organizations_path %>
         </li>
@@ -112,7 +112,7 @@
         <span class="icon-banner"></span>
         <strong><%= t("admin.menu.title_banners") %></strong>
       </a>
-      <ul <%= "class=is-active" if menu_banners %>>
+      <ul <%= "class=is-active" if menu_banners? %>>
         <li <%= "class=active" if controller_name == "banners" %>>
           <%= link_to t("admin.menu.banner"), admin_banners_path %>
         </li>