Merge pull request #6124 from consuldemocracy/menu_button_flashing

Don't flash the menu button on desktop screens

app/assets/stylesheets/layout.scss

@@ -588,18 +588,6 @@ body > header,
   }
 }
 
-.menu-button {
-  border: 1px solid;
-  border-radius: $button-radius;
-  color: inherit;
-  padding: 0.6em;
-}
-
-.menu-icon {
-  @include hamburger($color: currentcolor, $color-hover: currentcolor);
-  cursor: inherit;
-}
-
 .dropdown.menu > li {
 
   a {

app/assets/stylesheets/layout/responsive_menu.scss

@@ -0,0 +1,17 @@
+[data-responsive-toggle=responsive_menu] {
+  @include breakpoint(medium) {
+    display: none;
+  }
+
+  .menu-button {
+    border: 1px solid;
+    border-radius: $button-radius;
+    color: inherit;
+    padding: 0.6em;
+  }
+
+  .menu-icon {
+    @include hamburger($color: currentcolor, $color-hover: currentcolor);
+    cursor: inherit;
+  }
+}

app/components/layout/responsive_menu_component.html.erb

@@ -1,4 +1,4 @@
-<span data-responsive-toggle="responsive_menu" data-hide-for="medium">
+<span data-responsive-toggle="responsive_menu">
   <button type="button" class="menu-button" data-toggle>
     <span class="menu-icon"></span>
     <%= t("application.menu") %>