From a3a44f527b7439e09f1c03035e14d82348bf1ab5 Mon Sep 17 00:00:00 2001
From: taitus <sebastia.roig@gmail.com>
Date: Fri, 24 Oct 2025 09:47:52 +0200
Subject: [PATCH] Give purpose to previously unused on_budget_investments scope

The "on_budget_investments" scope in Activity has never been used
anywhere in the codebase. It was introduced in commit d9d38482b34
("extends Activity to include Investment valuations") but no references
were ever added.

Instead of removing it, we make use of the scope by adding the missing
"Budget investments" filter to the admin Activity section. This aligns
it with the rest of the activity filters and gives the scope the purpose
it was originally intended for.
---
 app/controllers/admin/activity_controller.rb |  2 +-
 config/locales/en/admin.yml                  |  1 +
 config/locales/es/admin.yml                  |  1 +
 spec/system/admin/activity_spec.rb           | 71 ++++++++++++++++++++
 4 files changed, 74 insertions(+), 1 deletion(-)

diff --git a/app/controllers/admin/activity_controller.rb b/app/controllers/admin/activity_controller.rb
index 5cb86abc5..99e97c535 100644
--- a/app/controllers/admin/activity_controller.rb
+++ b/app/controllers/admin/activity_controller.rb
@@ -1,5 +1,5 @@
 class Admin::ActivityController < Admin::BaseController
-  has_filters %w[all on_users on_proposals on_debates on_comments on_system_emails]
+  has_filters %w[all on_users on_proposals on_debates on_comments on_budget_investments on_system_emails]
 
   def show
     @activity = Activity.for_render.send(@current_filter)
diff --git a/config/locales/en/admin.yml b/config/locales/en/admin.yml
index d6917a5e5..44fb8d57a 100644
--- a/config/locales/en/admin.yml
+++ b/config/locales/en/admin.yml
@@ -62,6 +62,7 @@ en:
         filter: Show
         filters:
           all: All
+          on_budget_investments: Investment projects
           on_comments: Comments
           on_debates: Debates
           on_proposals: Proposals
diff --git a/config/locales/es/admin.yml b/config/locales/es/admin.yml
index 8db768fed..6fbc020c5 100644
--- a/config/locales/es/admin.yml
+++ b/config/locales/es/admin.yml
@@ -62,6 +62,7 @@ es:
         filter: Mostrar
         filters:
           all: Todos
+          on_budget_investments: Proyectos de gasto
           on_comments: Comentarios
           on_debates: Debates
           on_proposals: Propuestas
diff --git a/spec/system/admin/activity_spec.rb b/spec/system/admin/activity_spec.rb
index e92270c2b..8789af663 100644
--- a/spec/system/admin/activity_spec.rb
+++ b/spec/system/admin/activity_spec.rb
@@ -378,4 +378,75 @@ describe "Admin activity" do
       end
     end
   end
+
+  context "Budget investments" do
+    scenario "Shows moderation activity on budget investments" do
+      investment = create(:budget_investment, description: "<p>Investment description</p>")
+
+      visit budget_investment_path(investment.budget, investment)
+
+      within "#budget_investment_#{investment.id}" do
+        accept_confirm("Are you sure? Hide") { click_button "Hide" }
+      end
+
+      expect(page).to have_css "#budget_investment_#{investment.id}.faded"
+
+      visit admin_activity_path
+
+      within first("tbody tr") do
+        expect(page).to have_content(investment.title)
+        expect(page).to have_content("Hidden")
+        expect(page).to have_content(admin.user.username)
+        expect(page).to have_css("p", exact_text: "Investment description")
+      end
+    end
+
+    scenario "Shows moderation activity from moderation screen" do
+      investment1 = create(:budget_investment)
+      investment2 = create(:budget_investment)
+      investment3 = create(:budget_investment)
+
+      visit moderation_budget_investments_path(filter: "all")
+
+      within "#investment_#{investment1.id}" do
+        check "budget_investment_#{investment1.id}_check"
+      end
+
+      within "#investment_#{investment3.id}" do
+        check "budget_investment_#{investment3.id}_check"
+      end
+
+      accept_confirm("Are you sure? Hide budget investments") do
+        click_button "Hide budget investments"
+      end
+
+      expect(page).not_to have_content(investment1.title)
+
+      visit admin_activity_path(filter: "on_budget_investments")
+
+      expect(page).to have_content(investment1.title)
+      expect(page).not_to have_content(investment2.title)
+      expect(page).to have_content(investment3.title)
+    end
+
+    scenario "Shows admin restores" do
+      investment = create(:budget_investment, :hidden)
+
+      visit admin_hidden_budget_investments_path
+
+      within "#budget_investment_#{investment.id}" do
+        accept_confirm("Are you sure? Restore") { click_button "Restore" }
+      end
+
+      expect(page).to have_content "There are no hidden budget investments"
+
+      visit admin_activity_path
+
+      within first("tbody tr") do
+        expect(page).to have_content(investment.title)
+        expect(page).to have_content("Restored")
+        expect(page).to have_content(admin.user.username)
+      end
+    end
+  end
 end