From a38cdb4df33eaefb9f30f23ce7ced06743b94dbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Sun, 12 Jul 2020 23:41:02 +0200 Subject: [PATCH] Remove unnecessary safe navigation operator The heading is used with `find_by_slug_or_id`, which raises an exception if it isn't found, so executing `@heading.group` after it does not need the safe navigation operator. --- app/controllers/budgets/investments_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/budgets/investments_controller.rb b/app/controllers/budgets/investments_controller.rb index 9728c8ef3..541f40e44 100644 --- a/app/controllers/budgets/investments_controller.rb +++ b/app/controllers/budgets/investments_controller.rb @@ -148,7 +148,7 @@ module Budgets def load_heading if params[:heading_id].present? @heading = @budget.headings.find_by_slug_or_id! params[:heading_id] - @assigned_heading = @ballot&.heading_for_group(@heading&.group) + @assigned_heading = @ballot&.heading_for_group(@heading.group) load_map end end