From a3534e1f93a4bcbe244d32e2fb29c7d4e14a2175 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Tue, 5 Nov 2019 18:18:47 +0100 Subject: [PATCH] Use `presence` to simplify code --- app/views/admin/valuators/show.html.erb | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/app/views/admin/valuators/show.html.erb b/app/views/admin/valuators/show.html.erb index ebe1ec87c..f97115c24 100644 --- a/app/views/admin/valuators/show.html.erb +++ b/app/views/admin/valuators/show.html.erb @@ -13,27 +13,15 @@

<%= t("admin.valuators.show.description") %>
- <% if @valuator.description.present? %> - <%= @valuator.description %> - <% else %> - <%= t("admin.valuators.show.no_description") %> - <% end %> + <%= @valuator.description.presence || t("admin.valuators.show.no_description") %>

<%= t("admin.valuators.show.group") %>
- <% if @valuator.valuator_group.present? %> - <%= @valuator.valuator_group.try(:name) %> - <% else %> - <%= t("admin.valuators.show.no_group") %> - <% end %> + <%= @valuator.valuator_group&.name || t("admin.valuators.show.no_group") %>

<%= t("admin.valuators.show.abilities") %>
- <% if valuator_abilities(@valuator).present? %> - <%= valuator_abilities(@valuator) %> - <% else %> - <%= t("admin.valuators.show.no_abilities") %> - <% end %> + <%= valuator_abilities(@valuator).presence || t("admin.valuators.show.no_abilities") %>