consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make map location HTML class names consistent

Browse Source 
We were using `map_location` in one place and
`location-map-remove-marker` in another one. We usually use dashes in
HTML class names, we don't say "location map" anywhere else.
This commit is contained in:
Javi Martín
2023-05-02 15:47:14 +02:00
parent f4ef6412b6
commit a145fdb8a8
6 changed files with 40 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/system/budgets/budgets_spec.rb
View File

@@ -270,7 +270,7 @@ describe "Budgets" do
visit budgets_path
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 3, visible: :all)
end
end
@@ -290,7 +290,7 @@ describe "Budgets" do
visit budgets_path
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 4, visible: :all)
end
end
@@ -310,7 +310,7 @@ describe "Budgets" do
visit budgets_path
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 2, visible: :all)
end
end
@@ -338,7 +338,7 @@ describe "Budgets" do
visit budgets_path
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 1, visible: :all)
end
end

14
spec/system/budgets/investments_spec.rb
View File

@@ -122,7 +122,7 @@ describe "Budget Investments" do
create(:budget_investment, heading: heading)
visit budget_investments_path(budget, heading_id: heading.id)
within("#sidebar") do
expect(page).to have_css(".map_location")
expect(page).to have_css(".map-location")
end
unlocated_heading = create(:budget_heading, name: "No Map", price: 500, group: group,
@@ -130,7 +130,7 @@ describe "Budget Investments" do
create(:budget_investment, heading: unlocated_heading)
visit budget_investments_path(budget, heading_id: unlocated_heading.id)
within("#sidebar") do
expect(page).not_to have_css(".map_location")
expect(page).not_to have_css(".map-location")
end
end
@@ -1637,7 +1637,7 @@ describe "Budget Investments" do
visit budget_investments_path(budget, heading_id: heading.id)
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 6, visible: :all)
end
end
@@ -1651,7 +1651,7 @@ describe "Budget Investments" do
visit budget_investments_path(budget, heading_id: heading.id)
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 2, visible: :all)
end
end
@@ -1675,7 +1675,7 @@ describe "Budget Investments" do
visit budget_investments_path(budget, heading_id: heading.id)
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 4, visible: :all)
end
end
@@ -1693,7 +1693,7 @@ describe "Budget Investments" do
visit budget_investments_path(budget, heading_id: heading.id)
within ".map_location" do
within ".map-location" do
expect(page).to have_css(".map-icon", count: 0, visible: :all)
end
end
@@ -1711,7 +1711,7 @@ describe "Budget Investments" do
expect(page).to have_css(".budget-investment", count: 2)
end
within(".map_location") do
within(".map-location") do
expect(page).to have_css(".map-icon", count: 3, visible: :all)
end
end