From 9beb1608c42c80f0e829f8cc2f5d26dd30505ddd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Fri, 29 Mar 2024 20:27:22 +0100 Subject: [PATCH] Remove alt attribute in avatar images These images are always displayed next to a username, meaning people using screen readers were hearing the same username twice in a row. Even though we're about to replace the initialjs gem, we're making this change in case so we've got one more test and we can check everything keeps working after replacing the gem. --- app/components/shared/avatar_component.rb | 2 +- spec/components/shared/avatar_component_spec.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 spec/components/shared/avatar_component_spec.rb diff --git a/app/components/shared/avatar_component.rb b/app/components/shared/avatar_component.rb index a54618ec4..bd9fa7813 100644 --- a/app/components/shared/avatar_component.rb +++ b/app/components/shared/avatar_component.rb @@ -10,7 +10,7 @@ class Shared::AvatarComponent < ApplicationComponent private def default_options - { background_color: colors[seed % colors.size] } + { background_color: colors[seed % colors.size], alt: "" } end def options diff --git a/spec/components/shared/avatar_component_spec.rb b/spec/components/shared/avatar_component_spec.rb new file mode 100644 index 000000000..3fbb83a85 --- /dev/null +++ b/spec/components/shared/avatar_component_spec.rb @@ -0,0 +1,10 @@ +require "rails_helper" + +describe Shared::AvatarComponent do + it "does not contain redundant text already present around it" do + render_inline Shared::AvatarComponent.new(double(id: 1, name: "Johnny")) + + expect(page).to have_css "img", count: 1 + expect(page).to have_css "img[alt='']" + end +end