From 99bbad9b1ed111707d29c7cff976f9712246a0bd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 9 Aug 2021 19:20:07 +0200 Subject: [PATCH] Add and apply Style/RedundantCondition rule This is a rule we generally follow all the time but accidentally forgot in one place. --- .rubocop.yml | 3 +++ app/helpers/welcome_helper.rb | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index d4e0a52e8..2a0845b42 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -455,6 +455,9 @@ Style/Proc: Style/RaiseArgs: Enabled: true +Style/RedundantCondition: + Enabled: true + Style/RedundantFileExtensionInRequire: Enabled: true diff --git a/app/helpers/welcome_helper.rb b/app/helpers/welcome_helper.rb index 85cc2dd33..5962ff682 100644 --- a/app/helpers/welcome_helper.rb +++ b/app/helpers/welcome_helper.rb @@ -34,7 +34,7 @@ module WelcomeHelper def calculate_carousel_size(debates, proposals, apply_offset) offset = calculate_offset(debates, proposals, apply_offset) centered = calculate_centered(debates, proposals) - "#{offset if offset} #{centered if centered}" + "#{offset} #{centered}" end def calculate_centered(debates, proposals)