From 9981202c45868ec7493951702d2f677c7a66a850 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Wed, 31 Mar 2021 14:27:19 +0200 Subject: [PATCH] Add missing feature flag detection specs --- .../admin/budget_investments_controller_spec.rb | 8 ++++++++ .../controllers/budgets/investments_controller_spec.rb | 10 ++++++++++ spec/controllers/budgets_controller_spec.rb | 8 ++++++++ 3 files changed, 26 insertions(+) diff --git a/spec/controllers/admin/budget_investments_controller_spec.rb b/spec/controllers/admin/budget_investments_controller_spec.rb index 785cd230f..6fd1cc4e7 100644 --- a/spec/controllers/admin/budget_investments_controller_spec.rb +++ b/spec/controllers/admin/budget_investments_controller_spec.rb @@ -2,6 +2,14 @@ require "rails_helper" describe Admin::BudgetInvestmentsController, :admin do describe "GET index" do + it "raises an exception when the feature is disabled" do + Setting["process.budgets"] = false + + expect do + get :index, params: { budget_id: create(:budget).id } + end.to raise_exception(FeatureFlags::FeatureDisabled) + end + it "raises an error if budget slug is not found" do expect do get :index, params: { budget_id: "wrong_budget" } diff --git a/spec/controllers/budgets/investments_controller_spec.rb b/spec/controllers/budgets/investments_controller_spec.rb index a75172bfe..b486e9b10 100644 --- a/spec/controllers/budgets/investments_controller_spec.rb +++ b/spec/controllers/budgets/investments_controller_spec.rb @@ -1,6 +1,16 @@ require "rails_helper" describe Budgets::InvestmentsController do + describe "GET index" do + it "raises an exception when the feature is disabled" do + Setting["process.budgets"] = false + + expect do + get :index, params: { budget_id: create(:budget).id } + end.to raise_exception(FeatureFlags::FeatureDisabled) + end + end + describe "GET show" do let(:investment) { create(:budget_investment) } diff --git a/spec/controllers/budgets_controller_spec.rb b/spec/controllers/budgets_controller_spec.rb index 141255f4f..494d5e8a2 100644 --- a/spec/controllers/budgets_controller_spec.rb +++ b/spec/controllers/budgets_controller_spec.rb @@ -1,6 +1,14 @@ require "rails_helper" describe BudgetsController do + describe "GET index" do + it "raises an exception when the feature is disabled" do + Setting["process.budgets"] = false + + expect { get :index }.to raise_exception(FeatureFlags::FeatureDisabled) + end + end + describe "GET show" do it "raises an error if budget slug is not found" do expect do