From 974c4d6d705de1e0921dc745cacc5468ea6c026f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= <jjbazan@gmail.com>
Date: Thu, 8 Sep 2016 12:43:06 +0200
Subject: [PATCH] adds specs for proposal ballots

---
 .../_featured_successfull_proposal.html.erb   |  2 +-
 app/views/proposals/index.html.erb            |  2 +-
 app/views/proposals/show.html.erb             | 20 +++----
 spec/features/proposal_ballots_spec.rb        | 58 +++++++++++++++++++
 spec/support/common_actions.rb                |  5 ++
 5 files changed, 75 insertions(+), 12 deletions(-)
 create mode 100644 spec/features/proposal_ballots_spec.rb

diff --git a/app/views/proposal_ballots/_featured_successfull_proposal.html.erb b/app/views/proposal_ballots/_featured_successfull_proposal.html.erb
index 97754ce9c..3cc18a992 100644
--- a/app/views/proposal_ballots/_featured_successfull_proposal.html.erb
+++ b/app/views/proposal_ballots/_featured_successfull_proposal.html.erb
@@ -1,3 +1,3 @@
-<div id="<%= dom_id(proposal) %>" class="proposal-sucessfull">
+<div id="<%= dom_id(proposal) %>_next_voting" class="proposal-sucessfull">
   <h3><%= link_to proposal.title, proposal_ballots_path %></h3>
 </div>
diff --git a/app/views/proposals/index.html.erb b/app/views/proposals/index.html.erb
index 93574c1ad..5dee606d0 100644
--- a/app/views/proposals/index.html.erb
+++ b/app/views/proposals/index.html.erb
@@ -32,7 +32,7 @@
       <% end %>
 
       <% if @proposal_ballots.present? %>
-        <div class="row featured-proposals-ballot-banner margin-bottom">
+        <div id="next-voting" class="row featured-proposals-ballot-banner margin-bottom">
           <div class="small-12 column padding">
             <div class="icon-successfull"></div>
             <h2>
diff --git a/app/views/proposals/show.html.erb b/app/views/proposals/show.html.erb
index 06db46216..f19a21f71 100644
--- a/app/views/proposals/show.html.erb
+++ b/app/views/proposals/show.html.erb
@@ -102,19 +102,19 @@
       <aside class="small-12 medium-3 column">
         <div class="sidebar-divider"></div>
         <h3><%= t("votes.supports") %></h3>
-        <% if @proposal.successfull? %>
-          <p>
-            <%= t("proposal_ballots.successfull",
-                voting: link_to(t("proposal_ballots.voting"), proposal_ballots_path)).html_safe %>
-          </p>
-        <% else %>
-          <div class="text-center">
-            <div id="<%= dom_id(@proposal) %>_votes">
+        <div id="<%= dom_id(@proposal) %>_votes">
+          <% if @proposal.successfull? %>
+            <p>
+              <%= t("proposal_ballots.successfull",
+                  voting: link_to(t("proposal_ballots.voting"), proposal_ballots_path)).html_safe %>
+            </p>
+          <% else %>
+            <div class="text-center">
              <%= render 'votes',
                         { proposal: @proposal, vote_url: vote_proposal_path(@proposal, value: 'yes') } %>
             </div>
-          </div>
-        <% end %>
+          <% end %>
+        </div>
 
         <div id="social-share" class="sidebar-divider"></div>
         <h3><%= t("proposals.show.share") %></h3>
diff --git a/spec/features/proposal_ballots_spec.rb b/spec/features/proposal_ballots_spec.rb
new file mode 100644
index 000000000..e7bf310b1
--- /dev/null
+++ b/spec/features/proposal_ballots_spec.rb
@@ -0,0 +1,58 @@
+# coding: utf-8
+require 'rails_helper'
+
+feature 'Proposal ballots' do
+
+  scenario 'Banner shows in proposal index' do
+    create_featured_proposals
+
+    visit proposals_path
+    expect(page).to_not have_css("#next-voting")
+    expect(page).to have_css("#featured-proposals")
+
+    create_successfull_proposals
+
+    visit proposals_path
+
+    expect(page).to have_css("#next-voting")
+    expect(page).to_not have_css("#featured-proposals")
+  end
+
+  scenario 'Successfull proposals do not show support buttons in index' do
+    successfull_proposals = create_successfull_proposals
+
+    visit proposals_path
+
+    successfull_proposals.each do |proposal|
+      within("#proposal_#{proposal.id}_votes") do
+        expect(page).to_not have_css(".supports")
+        expect(page).to have_content "This proposal has reached the required supports"
+      end
+    end
+  end
+
+  scenario 'Successfull proposals do not show support buttons in show' do
+    successfull_proposals = create_successfull_proposals
+
+    successfull_proposals.each do |proposal|
+      visit proposal_path(proposal)
+      within("#proposal_#{proposal.id}_votes") do
+        expect(page).to_not have_css(".supports")
+        expect(page).to have_content "This proposal has reached the required supports"
+      end
+    end
+  end
+
+  scenario 'Successfull proposals are listed in the proposal ballots index' do
+    successfull_proposals = create_successfull_proposals
+
+    visit proposal_ballots_path
+
+    successfull_proposals.each do |proposal|
+      expect(page).to have_content(proposal.title)
+      expect(page).to have_content(proposal.question)
+    end
+  end
+
+end
+
diff --git a/spec/support/common_actions.rb b/spec/support/common_actions.rb
index 60d6641bf..8eaa49d4b 100644
--- a/spec/support/common_actions.rb
+++ b/spec/support/common_actions.rb
@@ -192,6 +192,11 @@ module CommonActions
      create(:debate, :with_confidence_score, cached_votes_up: 80)]
   end
 
+  def create_successfull_proposals
+    [create(:proposal, title: "Winter is coming", question: "Do you speak it?", cached_votes_up: Proposal.votes_needed_for_success + 100),
+     create(:proposal, title: "Fire and blood", question: "You talking to me?", cached_votes_up: Proposal.votes_needed_for_success + 1)]
+  end
+
   def tag_names(tag_cloud)
     tag_cloud.tags.map(&:name)
   end