diff --git a/.rubocop.yml b/.rubocop.yml index 8f52dad0d..37ef049be 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -291,9 +291,6 @@ Rails/HttpStatus: RSpec/RepeatedDescription: Enabled: true -RSpec/RepeatedExample: - Enabled: true - RSpec/ReturnFromStub: Enabled: true diff --git a/.rubocop_basic.yml b/.rubocop_basic.yml index 2301d4072..452eef9f7 100644 --- a/.rubocop_basic.yml +++ b/.rubocop_basic.yml @@ -169,6 +169,9 @@ RSpec/LetSetup: RSpec/NotToNot: Enabled: true +RSpec/RepeatedExample: + Enabled: true + Style/PercentLiteralDelimiters: Enabled: true diff --git a/spec/features/budgets/investments_spec.rb b/spec/features/budgets/investments_spec.rb index 0894d9314..4e5c70250 100644 --- a/spec/features/budgets/investments_spec.rb +++ b/spec/features/budgets/investments_spec.rb @@ -1292,24 +1292,6 @@ describe "Budget Investments" do expect(page).not_to have_content("Local government is not competent in this matter") end - scenario "Show (unfeasible budget investment with valuation not finished)" do - user = create(:user) - login_as(user) - - investment = create(:budget_investment, - :unfeasible, - valuation_finished: false, - budget: budget, - group: group, - heading: heading, - unfeasibility_explanation: "Local government is not competent in this matter") - - visit budget_investment_path(budget, id: investment.id) - - expect(page).not_to have_content("Unfeasibility explanation") - expect(page).not_to have_content("Local government is not competent in this matter") - end - it_behaves_like "followable", "budget_investment", "budget_investment_path", { "budget_id": "budget_id", "id": "id" } it_behaves_like "imageable", "budget_investment", "budget_investment_path", { "budget_id": "budget_id", "id": "id" } diff --git a/spec/models/abilities/valuator_spec.rb b/spec/models/abilities/valuator_spec.rb index 324292ca5..c50f9adfd 100644 --- a/spec/models/abilities/valuator_spec.rb +++ b/spec/models/abilities/valuator_spec.rb @@ -27,12 +27,6 @@ describe Abilities::Valuator do should_not be_able_to(:valuate, assigned_investment) end - it "cannot valuate an assigned investment with a finished valuation" do - assigned_investment.update(valuation_finished: true) - - should_not be_able_to(:valuate, assigned_investment) - end - it { should_not be_able_to(:update, non_assigned_investment) } it { should_not be_able_to(:valuate, non_assigned_investment) }