consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add an apply RSpec/StringAsInstanceDoubleConstant rubocop rule

Browse Source 
This rule was added in 3.1.0. Applying it allows you to start defining a way of doing
this in the project, helping to maintain consistency.
This commit is contained in:
taitus
2024-10-08 18:43:07 +02:00
parent f26ff44067
commit 9300fe5a58
3 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/helpers/comments_helper_spec.rb
View File

@@ -13,8 +13,8 @@ require "rails_helper"
RSpec.describe CommentsHelper do
describe "#user_level_class" do
def comment_double(as_administrator: false, as_moderator: false, official: false)
user = instance_double("User", official?: official, official_level: "Y")
instance_double("Comment", as_administrator?: as_administrator, as_moderator?: as_moderator, user: user)
user = instance_double(User, official?: official, official_level: "Y")
instance_double(Comment, as_administrator?: as_administrator, as_moderator?: as_moderator, user: user)
end
it "returns is-admin for comment done as administrator" do
@@ -45,14 +45,14 @@ RSpec.describe CommentsHelper do
describe "#comment_author_class" do
it "returns is-author if author is the commenting user" do
author_id = 42
comment = instance_double("Comment", user_id: author_id)
comment = instance_double(Comment, user_id: author_id)
expect(helper.comment_author_class(comment, author_id)).to eq("is-author")
end
it "returns an empty string if commenter is not the author" do
author_id = 42
comment = instance_double("Comment", user_id: author_id - 1)
comment = instance_double(Comment, user_id: author_id - 1)
expect(helper.comment_author_class(comment, author_id)).to eq("")
end