consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use JavaScript in system tests by default

Browse Source 
JavaScript is used by about 98% of web users, so by testing without it
enabled, we're only testing that the application works for a very
reduced number of users.

We proceeded this way in the past because CONSUL started using Rails 4.2
and truncating the database between JavaScript tests with database
cleaner, which made these tests terribly slow.

When we upgraded to Rails 5.1 and introduced system tests, we started
using database transactions in JavaScript tests, making these tests much
faster. So now we can use JavaScript tests everywhere without critically
slowing down our test suite.
This commit is contained in:
Javi Martín
2021-04-01 17:55:31 +02:00
parent 424fe7f5d2
commit 92ddcb7aef
153 changed files with 859 additions and 862 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/system/proposal_notifications_spec.rb
View File

@@ -75,7 +75,7 @@ describe "Proposal Notifications" do
expect(Notification.count).to eq(0)
end
scenario "Show notifications", :js do
scenario "Show notifications" do
proposal = create(:proposal)
create(:proposal_notification,
@@ -176,7 +176,7 @@ describe "Proposal Notifications" do
end
context "In-app notifications from the proposal's author" do
scenario "Voters who are followed should receive a notification", :js do
scenario "Voters who are followed should receive a notification" do
author = create(:user)
proposal = create(:proposal, author: author)
@@ -229,7 +229,7 @@ describe "Proposal Notifications" do
expect(page).to have_css ".notification", count: 0
end
scenario "Followers should receive a notification", :js do
scenario "Followers should receive a notification" do
author = create(:user)
proposal = create(:proposal, author: author)
@@ -282,7 +282,7 @@ describe "Proposal Notifications" do
expect(page).to have_css ".notification", count: 0
end
scenario "Proposal hidden", :js do
scenario "Proposal hidden" do
author = create(:user)
user = create(:user)
proposal = create(:proposal, author: author, voters: [user], followers: [user])
@@ -311,7 +311,7 @@ describe "Proposal Notifications" do
expect(page).to have_content "This resource is not available anymore"
end
scenario "Proposal retired by author", :js do
scenario "Proposal retired by author" do
author = create(:user)
user = create(:user)
proposal = create(:proposal, author: author, voters: [user])
@@ -327,7 +327,7 @@ describe "Proposal Notifications" do
Setting[:proposal_notification_minimum_interval_in_days] = 0
end
scenario "for the same proposal", :js do
scenario "for the same proposal" do
author = create(:user)
proposal = create(:proposal, author: author)
user = create(:user, followables: [proposal])