From 92633195d978db174537c93c9de785dcfceea412 Mon Sep 17 00:00:00 2001 From: kikito Date: Tue, 13 Jun 2017 12:19:02 +0200 Subject: [PATCH] refactors proposal_notification.public_for_api --- app/models/proposal_notification.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/proposal_notification.rb b/app/models/proposal_notification.rb index 25ae40883..9f36679a4 100644 --- a/app/models/proposal_notification.rb +++ b/app/models/proposal_notification.rb @@ -1,7 +1,7 @@ class ProposalNotification < ActiveRecord::Base include Graphqlable - + belongs_to :author, class_name: 'User', foreign_key: 'author_id' belongs_to :proposal @@ -10,7 +10,7 @@ class ProposalNotification < ActiveRecord::Base validates :proposal, presence: true validate :minimum_interval - scope :public_for_api, -> { joins(:proposal).where("proposals.hidden_at IS NULL") } + scope :public_for_api, -> { where(proposal_id: Proposal.public_for_api.pluck(:id)) } def minimum_interval return true if proposal.try(:notifications).blank?