From 86c9f53c2d058a0806b83fb9beaf984a845b9f74 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Wed, 3 Jul 2019 01:16:29 +0200
Subject: [PATCH] Use `undefined` instead of `void`

We originally wrote `undefined` in CoffeeScript.

CoffeeScript compiled it to `void 0` when generating the JavaScript
files. However, the reason to do so was the `undefined` variable was
mutable before ECMAScript 5. Using `undefined` is more intuitive, and
nowadays there's no reason to use `void 0`.
---
 .eslintrc.yml                                | 1 +
 app/assets/javascripts/cookies.js            | 3 +--
 app/assets/javascripts/forms.js              | 2 +-
 app/assets/javascripts/watch_form_changes.js | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.eslintrc.yml b/.eslintrc.yml
index 5eea83873..c50122ba3 100644
--- a/.eslintrc.yml
+++ b/.eslintrc.yml
@@ -36,6 +36,7 @@ rules:
   no-spaced-func: error
   no-tabs: error
   no-trailing-spaces: error
+  no-void: error
   no-whitespace-before-property: error
   object-curly-spacing:
     - error
diff --git a/app/assets/javascripts/cookies.js b/app/assets/javascripts/cookies.js
index 1f1af9b60..620c10dbd 100644
--- a/app/assets/javascripts/cookies.js
+++ b/app/assets/javascripts/cookies.js
@@ -1,10 +1,9 @@
-// Generated by CoffeeScript 1.12.6
 (function() {
   "use strict";
   App.Cookies = {
     saveCookie: function(name, value, days) {
       var date, expires;
-      expires = void 0;
+      expires = undefined;
       if (days) {
         date = new Date;
         date.setTime(date.getTime() + days * 24 * 60 * 60 * 1000);
diff --git a/app/assets/javascripts/forms.js b/app/assets/javascripts/forms.js
index 9c526aae4..d3120ab1d 100644
--- a/app/assets/javascripts/forms.js
+++ b/app/assets/javascripts/forms.js
@@ -18,7 +18,7 @@
       $(".js-toggle-link").unbind("click").on("click", function() {
         var toggle_txt;
         $($(this).data("toggle-selector")).toggle("down");
-        if ($(this).data("toggle-text") !== void 0) {
+        if ($(this).data("toggle-text") !== undefined) {
           toggle_txt = $(this).text();
           $(this).text($(this).data("toggle-text"));
           $(this).data("toggle-text", toggle_txt);
diff --git a/app/assets/javascripts/watch_form_changes.js b/app/assets/javascripts/watch_form_changes.js
index cbf9ec798..104d8d4d0 100644
--- a/app/assets/javascripts/watch_form_changes.js
+++ b/app/assets/javascripts/watch_form_changes.js
@@ -20,7 +20,7 @@
       }
     },
     initialize: function() {
-      if (App.WatchFormChanges.forms().length === 0 || App.WatchFormChanges.msg() === void 0) {
+      if (App.WatchFormChanges.forms().length === 0 || App.WatchFormChanges.msg() === undefined) {
         return;
       }
       $(document).off("page:before-change").on("page:before-change", App.WatchFormChanges.checkChanges);