From 9c13a331ec43a263315790c19fdd539062a8b4c5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Javi=20Mart=C3=ADn?= <javim@elretirao.net>
Date: Thu, 26 Jun 2025 13:32:51 +0200
Subject: [PATCH] Avoid side-effects when removing username message

In the registration form, after changing the username, we were removing
the message about whether a username was available. However, we were
also removing every `<small>` tag on the page. This affected the demo
branch, where we add a `<small>` tag on every page.

So we're now removing a specific element instead.
---
 app/assets/javascripts/registration_form.js | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/assets/javascripts/registration_form.js b/app/assets/javascripts/registration_form.js
index ecb827926..5c8f422bd 100644
--- a/app/assets/javascripts/registration_form.js
+++ b/app/assets/javascripts/registration_form.js
@@ -5,12 +5,16 @@
       var clearUsernameMessage, showUsernameMessage, usernameInput, validateUsername;
       usernameInput = $("form#new_user[action=\"/users\"] input#user_username");
       clearUsernameMessage = function() {
-        $("small").remove();
+        $("form#new_user .username-message").remove();
       };
       showUsernameMessage = function(response) {
         var klass;
         klass = response.available ? "no-error" : "error";
-        usernameInput.after($("<small class=\"" + klass + "\" style=\"margin-top: -16px;\">" + response.message + "</small>"));
+        usernameInput.after($(
+          "<small class=\"username-message " + klass + "\" style=\"margin-top: -16px;\">" +
+            response.message +
+            "</small>"
+        ));
       };
       validateUsername = function(username) {
         var request;