Merge pull request #3580 from consul/use_find_instead_of_find_by_id

Use find instead of find by

spec/features/admin/budget_groups_spec.rb

@@ -32,6 +32,43 @@ describe "Admin budget groups" do
 
   end
 
+  context "Load" do
+
+    let!(:budget) { create(:budget, slug: "budget_slug") }
+    let!(:group)  { create(:budget_group, slug: "group_slug", budget: budget) }
+
+    scenario "finds budget and group by slug" do
+      visit edit_admin_budget_group_path("budget_slug", "group_slug")
+      expect(page).to have_content(budget.name)
+      expect(page).to have_field "Group name", with: group.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit edit_admin_budget_group_path("wrong_budget", group)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit edit_admin_budget_group_path(0, group)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group slug is not found" do
+      expect do
+        visit edit_admin_budget_group_path(budget, "wrong_group")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group id is not found" do
+      expect do
+        visit edit_admin_budget_group_path(budget, 0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Displaying no groups for budget" do

spec/features/admin/budget_headings_spec.rb

@@ -33,6 +33,56 @@ describe "Admin budget headings" do
 
   end
 
+  context "Load" do
+
+    let!(:budget)  { create(:budget, slug: "budget_slug") }
+    let!(:group)   { create(:budget_group, slug: "group_slug", budget: budget) }
+    let!(:heading) { create(:budget_heading, slug: "heading_slug", group: group) }
+
+    scenario "finds budget, group and heading by slug" do
+      visit edit_admin_budget_group_heading_path("budget_slug", "group_slug", "heading_slug")
+      expect(page).to have_content(budget.name)
+      expect(page).to have_content(group.name)
+      expect(page).to have_field "Heading name", with: heading.name
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path("wrong_budget", group, heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(0, group, heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group slug is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, "wrong_group", heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if group id is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, 0, heading)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if heading slug is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, group, "wrong_heading")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if heading id is not found" do
+      expect do
+        visit edit_admin_budget_group_heading_path(budget, group, 0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+  end
+
   context "Index" do
 
     scenario "Displaying no headings for group" do

spec/features/admin/budget_investments_spec.rb

@@ -32,6 +32,34 @@ describe "Admin budget investments" do
 
   end
 
+  context "Load" do
+
+    let(:group)      { create(:budget_group, budget: budget) }
+    let(:heading)    { create(:budget_heading, group: group) }
+    let!(:investment) { create(:budget_investment, heading: heading) }
+
+    before { budget.update(slug: "budget_slug") }
+
+    scenario "finds investments using budget slug" do
+      visit admin_budget_budget_investments_path("budget_slug")
+
+      expect(page).to have_link investment.title
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit admin_budget_budget_investments_path("wrong_budget", investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit admin_budget_budget_investments_path(0, investment)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Displaying investments" do

spec/features/admin/budgets_spec.rb

@@ -24,6 +24,29 @@ describe "Admin budgets" do
 
   end
 
+  context "Load" do
+
+    let!(:budget) { create(:budget, slug: "budget_slug") }
+
+    scenario "finds budget by slug" do
+      visit admin_budget_path("budget_slug")
+      expect(page).to have_content(budget.name)
+    end
+
+    scenario "raises an error if budget slug is not found" do
+      expect do
+        visit admin_budget_path("wrong_budget")
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+    scenario "raises an error if budget id is not found" do
+      expect do
+        visit admin_budget_path(0)
+      end.to raise_error ActiveRecord::RecordNotFound
+    end
+
+  end
+
   context "Index" do
 
     scenario "Displaying no open budgets text" do