Open footer description links in the same window

This is a funny one, because we were accidentally opening them in the
same window without intending to do so since commit 928312e21, since the
`sanitize` method removes the `target` attribute. So the test we're
adding already passed without these changes.
This commit is contained in:
Javi Martín
2023-10-15 17:38:19 +02:00
parent 05345fb43c
commit 8053cc5e1c
2 changed files with 15 additions and 4 deletions

View File

@@ -8,12 +8,10 @@ class Layout::FooterComponent < ApplicationComponent
private private
def open_source_link def open_source_link
link_to(t("layouts.footer.open_source"), t("layouts.footer.open_source_url"), target: "_blank", link_to(t("layouts.footer.open_source"), t("layouts.footer.open_source_url"), rel: "nofollow")
rel: "nofollow")
end end
def repository_link def repository_link
link_to(t("layouts.footer.consul"), t("layouts.footer.consul_url"), target: "_blank", link_to(t("layouts.footer.consul"), t("layouts.footer.consul_url"), rel: "nofollow")
rel: "nofollow")
end end
end end

View File

@@ -0,0 +1,13 @@
require "rails_helper"
describe Layout::FooterComponent do
describe "description links" do
it "generates links that open in the same tab" do
render_inline Layout::FooterComponent.new
page.find(".info") do |info|
expect(info).not_to have_css "a[target]"
end
end
end
end