From 7f30d0c620f4bf7afaad0632efb8327f633d395e Mon Sep 17 00:00:00 2001 From: rgarcia Date: Tue, 20 Feb 2018 17:33:54 +0100 Subject: [PATCH] Fix doble submit specs We have a custom implementation to avoid doble submissions which causes some custom problems :relieved: This commit should fix the following three specs spec/features/comments/legislation_annotations_spec.rb:367 spec/features/comments/legislation_questions_spec.rb:333 spec/features/custom/probe_option_comments_spec.rb:298 One of the custom problems comes from ajax:success[1] not being triggered, instead only ajax:complete seems to be triggered We should remove this custom implementation and use the standard solution provided in rails[2] [1] https://github.com/AyuntamientoMadrid/consul/blob/master/app/assets/java scripts/prevent_double_submission.js.coffee#L28 [2] https://stackoverflow.com/questions/9570912/how-to-disable-a-form-submit -button-a-l%C3%A0-ruby-on-rails-way/9572893#9572893 --- .../javascripts/prevent_double_submission.js.coffee | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/prevent_double_submission.js.coffee b/app/assets/javascripts/prevent_double_submission.js.coffee index 743119c22..5f080ddfe 100644 --- a/app/assets/javascripts/prevent_double_submission.js.coffee +++ b/app/assets/javascripts/prevent_double_submission.js.coffee @@ -22,11 +22,15 @@ App.PreventDoubleSubmission = initialize: -> $('form').on('submit', (event) -> - unless event.target.id == "new_officing_voter" || "admin_download_emails" + unless event.target.id == "new_officing_voter" || + event.target.id == "admin_download_emails" + buttons = $(this).find(':button, :submit') App.PreventDoubleSubmission.disable_buttons(buttons) ).on('ajax:success', (event) -> - unless event.target.id == "new_officing_voter" + unless event.target.id == "new_officing_voter" || + event.target.id == "admin_download_emails" + buttons = $(this).find(':button, :submit') App.PreventDoubleSubmission.reset_buttons(buttons) )