consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify code to generate "See more" link

Browse Source 
We can skip the `link_to(*options) if options` part if we accept anchor
tags in the `link_list` helper.
This commit is contained in:
Javi Martín
2021-02-02 01:08:10 +01:00
parent fb611d91ca
commit 7c4515d6ce
5 changed files with 31 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
spec/helpers/link_list_helper_spec.rb
View File

@@ -19,6 +19,15 @@ describe LinkListHelper do
expect(list).to be_html_safe
end
it "accepts anchor tags" do
list = helper.link_list(link_to("Home", "/"), ["Info", "/info"], class: "menu")
expect(list).to eq '<ul class="menu">' +
'<li><a href="/">Home</a></li>' + "\n" +
'<li><a href="/info">Info</a></li></ul>'
expect(list).to be_html_safe
end
it "accepts options for links" do
render helper.link_list(["Home", "/", class: "root"], ["Info", "/info", id: "info"])
@@ -30,7 +39,15 @@ describe LinkListHelper do
it "ignores nil entries" do
render helper.link_list(["Home", "/", class: "root"], nil, ["Info", "/info", id: "info"])
expect(page).to have_css "a", count: 2
expect(page).to have_css "li", count: 2
expect(page).to have_css "a.root", count: 1, exact_text: "Home"
expect(page).to have_css "a#info", count: 1, exact_text: "Info"
end
it "ignores empty entries" do
render helper.link_list(["Home", "/", class: "root"], "", ["Info", "/info", id: "info"])
expect(page).to have_css "li", count: 2
expect(page).to have_css "a.root", count: 1, exact_text: "Home"
expect(page).to have_css "a#info", count: 1, exact_text: "Info"
end