consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant expectations in officing test

Browse Source 
We were checking that a field exists before interacting with it.
However, the methods that interact with fields already check whether the
field exists, so there's no need for us to check that.
This commit is contained in:
Javi Martín
2025-03-13 12:17:03 +01:00
parent 8e1c6f6db5
commit 7b6d6266e5
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/system/officing_spec.rb
View File

@@ -130,12 +130,11 @@ describe "Poll Officing" do
in_browser(:one) do in_browser(:one) do
visit new_officing_residence_path visit new_officing_residence_path
expect(page).to have_css "#residence_document_type"
select "DNI", from: "residence_document_type" select "DNI", from: "residence_document_type"
fill_in "residence_document_number", with: "12345678Z" fill_in "residence_document_number", with: "12345678Z"
fill_in "residence_year_of_birth", with: "1980" fill_in "residence_year_of_birth", with: "1980"
click_button "Validate document" click_button "Validate document"
expect(page).to have_content "Document verified with Census" expect(page).to have_content "Document verified with Census"
click_button "Confirm vote" click_button "Confirm vote"
expect(page).to have_content "Vote introduced!" expect(page).to have_content "Vote introduced!"
@@ -151,12 +150,11 @@ describe "Poll Officing" do
in_browser(:two) do in_browser(:two) do
visit new_officing_residence_path visit new_officing_residence_path
expect(page).to have_css "#residence_document_type"
select "DNI", from: "residence_document_type" select "DNI", from: "residence_document_type"
fill_in "residence_document_number", with: "12345678Y" fill_in "residence_document_number", with: "12345678Y"
fill_in "residence_year_of_birth", with: "1980" fill_in "residence_year_of_birth", with: "1980"
click_button "Validate document" click_button "Validate document"
expect(page).to have_content "Document verified with Census" expect(page).to have_content "Document verified with Census"
click_button "Confirm vote" click_button "Confirm vote"
expect(page).to have_content "Vote introduced!" expect(page).to have_content "Vote introduced!"