consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use caption instead of tr to label the answers table

Browse Source 
We might change the style of this caption or remove it completely in the
future. In the meantime, we use the right HTML tag for the task to give
information regarding what the table is about, and that tag is
`<caption>`.
This commit is contained in:
Javi Martín
2022-09-13 20:47:13 +02:00
committed by taitus
parent ec861ca8e6
commit 78ed5a8bfc
1 changed files with 10 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/views/admin/poll/questions/show.html.erb
View File

@@ -35,12 +35,8 @@
</div> </div>
<table class="margin-top"> <table class="margin-top">
<tr> <caption><%= t("admin.questions.show.valid_answers") %></caption>
<th colspan="5" scope="col" class="with-button"> <thead>
<%= t("admin.questions.show.valid_answers") %>
</th>
</tr>
<tr> <tr>
<th><%= t("admin.questions.show.answers.title") %></th> <th><%= t("admin.questions.show.answers.title") %></th>
<th scope="col" class="medium-7"><%= t("admin.questions.show.answers.description") %></th> <th scope="col" class="medium-7"><%= t("admin.questions.show.answers.description") %></th>
@@ -48,6 +44,7 @@
<th scope="col" class="text-center"><%= t("admin.questions.show.answers.documents") %></th> <th scope="col" class="text-center"><%= t("admin.questions.show.answers.documents") %></th>
<th scope="col" class="text-center"><%= t("admin.questions.show.answers.videos") %></th> <th scope="col" class="text-center"><%= t("admin.questions.show.answers.videos") %></th>
</tr> </tr>
</thead>
<tbody class="sortable" data-js-url="<%= admin_question_answers_order_answers_path(@question.id) %>"> <tbody class="sortable" data-js-url="<%= admin_question_answers_order_answers_path(@question.id) %>">
<% @question.question_answers.each do |answer| %> <% @question.question_answers.each do |answer| %>