Remove all Layout/EmptyLines issues on code and file list from rubocop_todo

This commit is contained in:
Bertocq
2017-06-25 16:01:31 +02:00
parent 2fa92937d2
commit 775da2d581
13 changed files with 0 additions and 28 deletions

View File

@@ -216,20 +216,6 @@ Style/EmptyCaseCondition:
Exclude: Exclude:
- 'app/models/concerns/verification.rb' - 'app/models/concerns/verification.rb'
# Offense count: 9
# Cop supports --auto-correct.
Layout/EmptyLines:
Exclude:
- 'app/models/concerns/search_cache.rb'
- 'app/models/notification.rb'
- 'spec/features/admin/spending_proposals_spec.rb'
- 'spec/features/admin/verifications_spec.rb'
- 'spec/features/debates_spec.rb'
- 'spec/features/registration_form_spec.rb'
- 'spec/features/users_auth_spec.rb'
- 'spec/features/verification/verified_user_spec.rb'
- 'spec/support/verifiable.rb'
# Offense count: 29 # Offense count: 29
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.

View File

@@ -31,5 +31,4 @@ module SearchCache
ActionController::Base.helpers.sanitize(value, tags: []) ActionController::Base.helpers.sanitize(value, tags: [])
end end
end end

View File

@@ -7,7 +7,6 @@ class Notification < ActiveRecord::Base
scope :not_emailed, -> { where(emailed_at: nil) } scope :not_emailed, -> { where(emailed_at: nil) }
scope :for_render, -> { includes(:notifiable) } scope :for_render, -> { includes(:notifiable) }
def timestamp def timestamp
notifiable.created_at notifiable.created_at
end end

View File

@@ -13,7 +13,6 @@ feature 'Admin feature flags' do
Setting['feature.spending_proposal_features.voting_allowed'] = nil Setting['feature.spending_proposal_features.voting_allowed'] = nil
end end
scenario 'Enabled features are listed on menu' do scenario 'Enabled features are listed on menu' do
visit admin_root_path visit admin_root_path

View File

@@ -634,7 +634,6 @@ feature 'Admin spending proposals' do
proposal5 = create(:spending_proposal, geozone: new_york, valuation_finished: true) proposal5 = create(:spending_proposal, geozone: new_york, valuation_finished: true)
proposal6 = create(:spending_proposal, geozone: new_york, valuation_finished: false) proposal6 = create(:spending_proposal, geozone: new_york, valuation_finished: false)
create(:vote, votable: proposal1) create(:vote, votable: proposal1)
create(:vote, votable: proposal2) create(:vote, votable: proposal2)
create(:vote, votable: proposal3) create(:vote, votable: proposal3)

View File

@@ -36,7 +36,6 @@ feature 'Incomplete verifications' do
expect(page).to_not have_content("Isabel_anonymous") expect(page).to_not have_content("Isabel_anonymous")
end end
scenario "Residence unverified" do scenario "Residence unverified" do
incompletely_verified_user = create(:user, :incomplete_verification) incompletely_verified_user = create(:user, :incomplete_verification)

View File

@@ -211,8 +211,6 @@ feature 'Debates' do
expect(page.html).to_not include "<script>alert('hey')</script>" expect(page.html).to_not include "<script>alert('hey')</script>"
end end
scenario 'Update should not be posible if logged user is not the author' do scenario 'Update should not be posible if logged user is not the author' do
debate = create(:debate) debate = create(:debate)
expect(debate).to be_editable expect(debate).to be_editable
@@ -947,7 +945,6 @@ feature 'Debates' do
end end
end end
scenario 'Index do not show featured debates if none is marked as featured' do scenario 'Index do not show featured debates if none is marked as featured' do
admin = create(:administrator) admin = create(:administrator)
login_as(admin.user) login_as(admin.user)

View File

@@ -78,5 +78,4 @@ feature 'Registration form' do
expect(current_path).to eq(new_user_registration_path) expect(current_path).to eq(new_user_registration_path)
end end
end end

View File

@@ -200,7 +200,6 @@ feature 'Users' do
expect(current_path).to eq(finish_signup_path) expect(current_path).to eq(finish_signup_path)
click_link 'Cancel login' click_link 'Cancel login'
visit '/' visit '/'
expect_to_not_be_signed_in expect_to_not_be_signed_in
end end

View File

@@ -76,7 +76,6 @@ feature 'Valuation budget investments' do
expect(page).to have_link("Realocate visitors") expect(page).to have_link("Realocate visitors")
expect(page).to have_link("Destroy the city") expect(page).to have_link("Destroy the city")
expect(page).to have_content "All headings (2)" expect(page).to have_content "All headings (2)"
expect(page).to have_content "District 9 (1)" expect(page).to have_content "District 9 (1)"
expect(page).to have_content "Down to the river (1)" expect(page).to have_content "Down to the river (1)"

View File

@@ -69,7 +69,6 @@ feature 'Verified users' do
expect(current_path).to eq new_sms_path expect(current_path).to eq new_sms_path
end end
scenario "Select a verified email" do scenario "Select a verified email" do
user = create(:user, user = create(:user,
residence_verified_at: Time.current, residence_verified_at: Time.current,

View File

@@ -590,7 +590,6 @@ describe Budget::Investment do
most_voted2 = create(:budget_investment, cached_votes_up: 10) most_voted2 = create(:budget_investment, cached_votes_up: 10)
least_voted2 = create(:budget_investment, cached_votes_up: 1) least_voted2 = create(:budget_investment, cached_votes_up: 1)
expect(Budget::Investment.sort_by_confidence_score.first).to eq most_voted2 expect(Budget::Investment.sort_by_confidence_score.first).to eq most_voted2
expect(Budget::Investment.sort_by_confidence_score.second).to eq most_voted expect(Budget::Investment.sort_by_confidence_score.second).to eq most_voted
expect(Budget::Investment.sort_by_confidence_score.third).to eq least_voted2 expect(Budget::Investment.sort_by_confidence_score.third).to eq least_voted2

View File

@@ -67,7 +67,6 @@ shared_examples_for "verifiable" do
user3 = create(:user, verified_at: nil, confirmed_phone: nil) user3 = create(:user, verified_at: nil, confirmed_phone: nil)
user4 = create(:user, verified_at: Time.current, residence_verified_at: Time.current, unconfirmed_phone: "123456789", confirmed_phone: "123456789") user4 = create(:user, verified_at: Time.current, residence_verified_at: Time.current, unconfirmed_phone: "123456789", confirmed_phone: "123456789")
expect(model.incomplete_verification).to include(user1) expect(model.incomplete_verification).to include(user1)
expect(model.incomplete_verification).to include(user2) expect(model.incomplete_verification).to include(user2)
expect(model.incomplete_verification).to_not include(user3) expect(model.incomplete_verification).to_not include(user3)