From 74e819e4e77c350b212c0016f3f27de07d1eb3f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 10 Sep 2020 21:27:22 +0200 Subject: [PATCH] Use "regular" instead of "r" as parameter Even if "r" is shorter, "regular" is easier to understand, and we're going to store these icons in a folder named "regular", which is the convention Font Awesome uses. --- app/assets/stylesheets/layout.scss | 4 ++-- app/assets/stylesheets/legislation_process.scss | 2 +- app/assets/stylesheets/mixins.scss | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 1c31dea89..d33e4ffa6 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -2113,12 +2113,12 @@ table { .responses-count { .show-children { - @include has-fa-icon(plus-square, r); + @include has-fa-icon(plus-square, regular); display: none; } .collapse-children { - @include has-fa-icon(minus-square, r); + @include has-fa-icon(minus-square, regular); } .show-children::before, diff --git a/app/assets/stylesheets/legislation_process.scss b/app/assets/stylesheets/legislation_process.scss index 8f3199c06..0d54f87ab 100644 --- a/app/assets/stylesheets/legislation_process.scss +++ b/app/assets/stylesheets/legislation_process.scss @@ -1060,7 +1060,7 @@ } .comments-count { - @include has-fa-icon(comments, r); + @include has-fa-icon(comments, regular); } .question-title:not(:only-child) { diff --git a/app/assets/stylesheets/mixins.scss b/app/assets/stylesheets/mixins.scss index db2678c55..3de0edd8d 100644 --- a/app/assets/stylesheets/mixins.scss +++ b/app/assets/stylesheets/mixins.scss @@ -150,7 +150,7 @@ @extend %fa-icon; font-family: "Font Awesome 5 Free"; - @if $style == "r" { + @if $style == "regular" { font-weight: normal; } @else { font-weight: bold;