Simplify HTML for an investment row

Since we define the `data-field` element, we can style each element
individually with CSS.

I'm not sure whether these styles make sense, though. For instance, why
is "Supports" aligned to the center, since it's a number? For now, we're
leaving it as it was.
This commit is contained in:
Javi Martín
2024-10-07 14:00:35 +02:00
parent 607dabbc8a
commit 73166e164b
2 changed files with 26 additions and 11 deletions

View File

@@ -0,0 +1,15 @@
.admin .admin-budget-investments {
td {
&[data-field=supports],
&[data-field=valuation_finished],
&[data-field=visible_to_valuators],
&[data-field=selected],
&[data-field=incompatible] {
text-align: center;
}
&:not([data-field=id], [data-field=title], [data-field=supports]) {
font-size: $small-font-size;
}
}
}

View File

@@ -7,41 +7,41 @@
<%= link_to investment.title, investment_path, target: "_blank" %> <%= link_to investment.title, investment_path, target: "_blank" %>
</td> </td>
<td class="text-center" data-field="supports"> <td data-field="supports">
<%= investment.total_votes %> <%= investment.total_votes %>
</td> </td>
<td class="small" data-field="admin"> <td data-field="admin">
<%= administrator_info %> <%= administrator_info %>
</td> </td>
<td class="small" data-field="author"> <td data-field="author">
<%= investment.author.name %> <%= investment.author.name %>
</td> </td>
<td class="small" data-field="valuator"> <td data-field="valuator">
<%= valuators_info %> <%= valuators_info %>
</td> </td>
<td class="small" data-field="geozone"> <td data-field="geozone">
<%= investment.heading.name %> <%= investment.heading.name %>
</td> </td>
<td class="small" data-field="feasibility"> <td data-field="feasibility">
<%= t("admin.budget_investments.index.feasibility.#{investment.feasibility}") %> <%= t("admin.budget_investments.index.feasibility.#{investment.feasibility}") %>
</td> </td>
<% if budget.show_money? %> <% if budget.show_money? %>
<td class="small" data-field="price"> <td data-field="price">
<%= investment.formatted_price %> <%= investment.formatted_price %>
</td> </td>
<% end %> <% end %>
<td class="small text-center" data-field="valuation_finished"> <td data-field="valuation_finished">
<%= investment.valuation_finished? ? t("shared.yes") : t("shared.no") %> <%= investment.valuation_finished? ? t("shared.yes") : t("shared.no") %>
</td> </td>
<td class="small text-center" data-field="visible_to_valuators"> <td data-field="visible_to_valuators">
<% if can?(:admin_update, investment) %> <% if can?(:admin_update, investment) %>
<%= form_for [:admin, budget, investment], remote: true, format: :json do |f| %> <%= form_for [:admin, budget, investment], remote: true, format: :json do |f| %>
<%= f.check_box :visible_to_valuators, <%= f.check_box :visible_to_valuators,
@@ -54,7 +54,7 @@
<% end %> <% end %>
</td> </td>
<td id="selection" class="small text-center" data-field="selected"> <td id="selection" data-field="selected">
<% if investment.selected? %> <% if investment.selected? %>
<%= link_to_if can?(:toggle_selection, investment), <%= link_to_if can?(:toggle_selection, investment),
t("admin.budget_investments.index.selected"), t("admin.budget_investments.index.selected"),
@@ -92,7 +92,7 @@
</td> </td>
<% if params[:advanced_filters]&.include?("selected") %> <% if params[:advanced_filters]&.include?("selected") %>
<td class="small text-center" data-field="incompatible"> <td data-field="incompatible">
<%= investment.incompatible? ? t("shared.yes") : t("shared.no") %> <%= investment.incompatible? ? t("shared.yes") : t("shared.no") %>
</td> </td>
<% end %> <% end %>