consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused parameter in imageable tests method

Browse Source
This commit is contained in:
Javi Martín
2021-07-27 19:32:36 +02:00
parent 04585d289c
commit 6f219beff0
5 changed files with 13 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
spec/shared/system/nested_imageable.rb
View File

@@ -47,10 +47,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
do_login_for user do_login_for user
visit send(path, arguments) visit send(path, arguments)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
imageable_factory_name,
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
expect_image_has_title("clippy.jpg") expect_image_has_title("clippy.jpg")
end end
@@ -75,10 +72,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
do_login_for user do_login_for user
visit send(path, arguments) visit send(path, arguments)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
imageable_factory_name,
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
expect(page).to have_selector ".loading-bar.complete" expect(page).to have_selector ".loading-bar.complete"
end end
@@ -87,11 +81,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
do_login_for user do_login_for user
visit send(path, arguments) visit send(path, arguments)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/logo_header.png"), false)
imageable_factory_name,
Rails.root.join("spec/fixtures/files/logo_header.png"),
false
)
expect(page).to have_selector ".loading-bar.errors" expect(page).to have_selector ".loading-bar.errors"
end end
@@ -100,10 +90,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
do_login_for user do_login_for user
visit send(path, arguments) visit send(path, arguments)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
imageable_factory_name,
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
expect_image_has_cached_attachment(".jpg") expect_image_has_cached_attachment(".jpg")
end end
@@ -112,11 +99,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
do_login_for user do_login_for user
visit send(path, arguments) visit send(path, arguments)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/logo_header.png"), false)
imageable_factory_name,
Rails.root.join("spec/fixtures/files/logo_header.png"),
false
)
expect_image_has_cached_attachment("") expect_image_has_cached_attachment("")
end end
@@ -141,10 +124,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
do_login_for user do_login_for user
visit send(path, arguments) visit send(path, arguments)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
imageable_factory_name,
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
within "#nested-image .image" do within "#nested-image .image" do
click_link "Remove image" click_link "Remove image"
@@ -171,10 +151,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
visit send(path, arguments) visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name send(fill_resource_method_name) if fill_resource_method_name
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
imageable_factory_name,
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
expect(page).to have_selector ".loading-bar.complete" expect(page).to have_selector ".loading-bar.complete"
@@ -188,10 +165,7 @@ shared_examples "nested imageable" do |imageable_factory_name, path, imageable_p
visit send(path, arguments) visit send(path, arguments)
send(fill_resource_method_name) if fill_resource_method_name send(fill_resource_method_name) if fill_resource_method_name
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
imageable_factory_name,
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
expect(page).to have_selector ".loading-bar.complete" expect(page).to have_selector ".loading-bar.complete"
@@ -255,7 +229,7 @@ def imageable_redirected_to_resource_show_or_navigate_to
end end
end end
def imageable_attach_new_file(_imageable_factory_name, path, success = true) def imageable_attach_new_file(path, success = true)
click_link "Add image" click_link "Add image"
within "#nested-image" do within "#nested-image" do
image = find(".image") image = find(".image")

5
spec/system/admin/budget_phases_spec.rb
View File

@@ -46,10 +46,7 @@ describe "Admin budget phases" do
scenario "shows successful notice when updating the phase with a valid image" do scenario "shows successful notice when updating the phase with a valid image" do
visit edit_admin_budget_budget_phase_path(budget, budget.current_phase) visit edit_admin_budget_budget_phase_path(budget, budget.current_phase)
imageable_attach_new_file( imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
"budget_phase_image",
Rails.root.join("spec/fixtures/files/clippy.jpg")
)
click_on "Save changes" click_on "Save changes"

2
spec/system/admin/legislation/processes_spec.rb
View File

@@ -175,7 +175,7 @@ describe "Admin collaborative legislation", :admin do
fill_in "End", with: base_date + 5.days fill_in "End", with: base_date + 5.days
end end
imageable_attach_new_file(create(:image), Rails.root.join("spec/fixtures/files/clippy.jpg")) imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
click_button "Create process" click_button "Create process"

3
spec/system/admin/poll/questions/answers/images/images_spec.rb
View File

@@ -32,14 +32,13 @@ describe "Images", :admin do
scenario "Add image to answer" do scenario "Add image to answer" do
answer = create(:poll_question_answer) answer = create(:poll_question_answer)
image = create(:image)
visit admin_answer_images_path(answer) visit admin_answer_images_path(answer)
expect(page).not_to have_css("img[title='clippy.jpg']") expect(page).not_to have_css("img[title='clippy.jpg']")
expect(page).not_to have_content("clippy.jpg") expect(page).not_to have_content("clippy.jpg")
visit new_admin_answer_image_path(answer) visit new_admin_answer_image_path(answer)
imageable_attach_new_file(image, Rails.root.join("spec/fixtures/files/clippy.jpg")) imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
click_button "Save image" click_button "Save image"
expect(page).to have_css("img[title='clippy.jpg']") expect(page).to have_css("img[title='clippy.jpg']")

2
spec/system/legislation/proposals_spec.rb
View File

@@ -146,7 +146,7 @@ describe "Legislation Proposals" do
fill_in "Proposal title", with: "Legislation proposal with image" fill_in "Proposal title", with: "Legislation proposal with image"
fill_in "Proposal summary", with: "Including an image on a legislation proposal" fill_in "Proposal summary", with: "Including an image on a legislation proposal"
imageable_attach_new_file(create(:image), Rails.root.join("spec/fixtures/files/clippy.jpg")) imageable_attach_new_file(Rails.root.join("spec/fixtures/files/clippy.jpg"))
check "legislation_proposal_terms_of_service" check "legislation_proposal_terms_of_service"
click_button "Create proposal" click_button "Create proposal"