From 6eebe4e9847149af75134fcb18f449d18e1b78e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Mon, 15 Apr 2024 04:08:12 +0200 Subject: [PATCH] Don't run commit callbacks on first saved instances in transaction It probably doesn't directly affect us, since we don't use `after_commit` callbacks, and, among our dependencies, AFAIK only the Devise gem uses them, to send the email with confirmation/reconfirmation instructions. The reasons for this change are explained in the guide to configure Rails [1], while the pull request introducing the change has a couple of great examples in its description [2]. [1] https://guides.rubyonrails.org/v7.1/configuring.html#config-active-record-run-commit-callbacks-on-first-saved-instances-in-transaction [2] Pull request 45280 in https://github.com/rails/rails --- config/initializers/new_framework_defaults_7_1.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/initializers/new_framework_defaults_7_1.rb b/config/initializers/new_framework_defaults_7_1.rb index 46ac5c22b..3d50a5cca 100644 --- a/config/initializers/new_framework_defaults_7_1.rb +++ b/config/initializers/new_framework_defaults_7_1.rb @@ -55,7 +55,7 @@ Rails.application.config.active_record.encryption.support_sha1_for_non_determini # state which matches what was committed to the database, typically the last # instance to save. #++ -# Rails.application.config.active_record.run_commit_callbacks_on_first_saved_instances_in_transaction = false +Rails.application.config.active_record.run_commit_callbacks_on_first_saved_instances_in_transaction = false ### # Configures SQLite with a strict strings mode, which disables double-quoted string literals.