Simplify expectations in "select all/none" tests

This commit is contained in:
Javi Martín
2024-04-12 17:40:04 +02:00
parent f8f4054614
commit 6ee5c0fcb8
5 changed files with 10 additions and 20 deletions

View File

@@ -114,13 +114,11 @@ describe "Moderate budget investments" do
within(".js-check") { click_link "All" } within(".js-check") { click_link "All" }
expect(all("input[type=checkbox]")).to all(be_checked) expect(all(:checkbox)).to all(be_checked)
within(".js-check") { click_link "None" } within(".js-check") { click_link "None" }
all("input[type=checkbox]").each do |checkbox| all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
expect(checkbox).not_to be_checked
end
end end
scenario "remembering page, filter and order" do scenario "remembering page, filter and order" do

View File

@@ -134,13 +134,11 @@ describe "Moderate comments" do
within(".js-check") { click_link "All" } within(".js-check") { click_link "All" }
expect(all("input[type=checkbox]")).to all(be_checked) expect(all(:checkbox)).to all(be_checked)
within(".js-check") { click_link "None" } within(".js-check") { click_link "None" }
all("input[type=checkbox]").each do |checkbox| all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
expect(checkbox).not_to be_checked
end
end end
scenario "remembering page, filter and order" do scenario "remembering page, filter and order" do

View File

@@ -103,13 +103,11 @@ describe "Moderate debates" do
within(".js-check") { click_link "All" } within(".js-check") { click_link "All" }
expect(all("input[type=checkbox]")).to all(be_checked) expect(all(:checkbox)).to all(be_checked)
within(".js-check") { click_link "None" } within(".js-check") { click_link "None" }
all("input[type=checkbox]").each do |checkbox| all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
expect(checkbox).not_to be_checked
end
end end
scenario "remembering page, filter and order" do scenario "remembering page, filter and order" do

View File

@@ -114,13 +114,11 @@ describe "Moderate proposal notifications" do
within(".js-check") { click_link "All" } within(".js-check") { click_link "All" }
expect(all("input[type=checkbox]")).to all(be_checked) expect(all(:checkbox)).to all(be_checked)
within(".js-check") { click_link "None" } within(".js-check") { click_link "None" }
all("input[type=checkbox]").each do |checkbox| all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
expect(checkbox).not_to be_checked
end
end end
scenario "remembering page, filter and order" do scenario "remembering page, filter and order" do

View File

@@ -102,13 +102,11 @@ describe "Moderate proposals" do
within(".js-check") { click_link "All" } within(".js-check") { click_link "All" }
expect(all("input[type=checkbox]")).to all(be_checked) expect(all(:checkbox)).to all(be_checked)
within(".js-check") { click_link "None" } within(".js-check") { click_link "None" }
all("input[type=checkbox]").each do |checkbox| all(:checkbox).each { |checkbox| expect(checkbox).not_to be_checked }
expect(checkbox).not_to be_checked
end
end end
scenario "remembering page, filter and order" do scenario "remembering page, filter and order" do