diff --git a/.rubocop.yml b/.rubocop.yml index 3c68ecce0..a423ca5af 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -50,4 +50,7 @@ Capybara/FeatureMethods: Enabled: false RSpec/ContextWording: - Enabled: false \ No newline at end of file + Enabled: false + +RSpec/DescribeClass: + Enabled: true \ No newline at end of file diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 73b5a98b6..228e49310 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -783,3 +783,17 @@ Style/SafeNavigation: Style/WordArray: EnforcedStyle: percent MinSize: 8 + +# Offense count: 9 +RSpec/DescribeClass: + Exclude: + - 'spec/customization_engine_spec.rb' + - 'spec/i18n_spec.rb' + - 'spec/lib/acts_as_paranoid_aliases_spec.rb' + - 'spec/lib/cache_spec.rb' + - 'spec/lib/graphql_spec.rb' + - 'spec/lib/tasks/communities_spec.rb' + - 'spec/lib/tasks/dev_seed_spec.rb' + - 'spec/lib/tasks/settings_spec.rb' + - 'spec/models/abilities/organization_spec.rb' + - 'spec/views/welcome/index.html.erb_spec.rb' \ No newline at end of file diff --git a/spec/controllers/concerns/has_filters_spec.rb b/spec/controllers/concerns/has_filters_spec.rb index af094e9ec..d0bfdf1e7 100644 --- a/spec/controllers/concerns/has_filters_spec.rb +++ b/spec/controllers/concerns/has_filters_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe 'HasFilters' do +describe HasFilters do class FakeController < ActionController::Base; end diff --git a/spec/controllers/concerns/has_orders_spec.rb b/spec/controllers/concerns/has_orders_spec.rb index fa2c49b07..b94cc2dba 100644 --- a/spec/controllers/concerns/has_orders_spec.rb +++ b/spec/controllers/concerns/has_orders_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe 'HasOrders' do +describe HasOrders do class FakeController < ActionController::Base; end diff --git a/spec/customization_engine_spec.rb b/spec/customization_engine_spec.rb index a18130543..08811e7d9 100644 --- a/spec/customization_engine_spec.rb +++ b/spec/customization_engine_spec.rb @@ -3,7 +3,7 @@ require 'rails_helper' # This module tests functionality related with custom application files # TODO test models, controllers, etc... -describe 'CustomizationEngine' do +describe 'Customization Engine' do let(:test_key) { I18n.t('account.show.change_credentials_link') } let!(:default_path) { I18n.load_path } diff --git a/spec/lib/acts_as_taggable_on_spec.rb b/spec/lib/acts_as_taggable_on_spec.rb index de53b35e7..4b9cb6756 100644 --- a/spec/lib/acts_as_taggable_on_spec.rb +++ b/spec/lib/acts_as_taggable_on_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe 'ActsAsTaggableOn' do +describe ActsAsTaggableOn do describe 'Tagging' do describe "when tagging debates or proposals" do diff --git a/spec/lib/graphql_spec.rb b/spec/lib/graphql_spec.rb index ce9cd9052..477291423 100644 --- a/spec/lib/graphql_spec.rb +++ b/spec/lib/graphql_spec.rb @@ -35,7 +35,7 @@ def extract_fields(response, collection_name, field_chain) end.compact end -describe 'ConsulSchema' do +describe 'Consul Schema' do let(:user) { create(:user) } let(:proposal) { create(:proposal, author: user) } diff --git a/spec/models/abilities/administrator_spec.rb b/spec/models/abilities/administrator_spec.rb index 0934c7cfe..51e94040f 100644 --- a/spec/models/abilities/administrator_spec.rb +++ b/spec/models/abilities/administrator_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require 'cancan/matchers' -describe "Abilities::Administrator" do +describe Abilities::Administrator do subject(:ability) { Ability.new(user) } let(:user) { administrator.user } let(:administrator) { create(:administrator) } diff --git a/spec/models/abilities/common_spec.rb b/spec/models/abilities/common_spec.rb index 7f936cfcf..c8789d48b 100644 --- a/spec/models/abilities/common_spec.rb +++ b/spec/models/abilities/common_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require 'cancan/matchers' -describe "Abilities::Common" do +describe Abilities::Common do subject(:ability) { Ability.new(user) } let(:geozone) { create(:geozone) } diff --git a/spec/models/abilities/everyone_spec.rb b/spec/models/abilities/everyone_spec.rb index 21568c999..2167c748d 100644 --- a/spec/models/abilities/everyone_spec.rb +++ b/spec/models/abilities/everyone_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require 'cancan/matchers' -describe "Abilities::Everyone" do +describe Abilities::Everyone do subject(:ability) { Ability.new(user) } let(:user) { nil } diff --git a/spec/models/abilities/moderator_spec.rb b/spec/models/abilities/moderator_spec.rb index f3135c8d9..d67804f3f 100644 --- a/spec/models/abilities/moderator_spec.rb +++ b/spec/models/abilities/moderator_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require 'cancan/matchers' -describe "Abilities::Moderator" do +describe Abilities::Moderator do subject(:ability) { Ability.new(user) } let(:user) { moderator.user } let(:moderator) { create(:moderator) } diff --git a/spec/models/abilities/organization_spec.rb b/spec/models/abilities/organization_spec.rb index 1d7687b64..3c1bc4feb 100644 --- a/spec/models/abilities/organization_spec.rb +++ b/spec/models/abilities/organization_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require 'cancan/matchers' -describe "Abilities::Organization" do +describe 'Abilities::Organization' do subject(:ability) { Ability.new(user) } let(:user) { organization.user } let(:organization) { create(:organization) } diff --git a/spec/models/abilities/valuator_spec.rb b/spec/models/abilities/valuator_spec.rb index c3735b43b..0d56158e2 100644 --- a/spec/models/abilities/valuator_spec.rb +++ b/spec/models/abilities/valuator_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' require 'cancan/matchers' -describe "Abilities::Valuator" do +describe Abilities::Valuator do subject(:ability) { Ability.new(user) } let(:user) { valuator.user } let(:valuator) { create(:valuator) } diff --git a/spec/models/budget/ballot/line_spec.rb b/spec/models/budget/ballot/line_spec.rb index e1da8a485..cbf55e949 100644 --- a/spec/models/budget/ballot/line_spec.rb +++ b/spec/models/budget/ballot/line_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe "Budget::Ballot::Line" do +describe Budget::Ballot::Line do let(:budget){ create(:budget) } let(:group){ create(:budget_group, budget: budget) } diff --git a/spec/models/budget/investment/milestone_spec.rb b/spec/models/budget/investment/milestone_spec.rb index c66c9cd39..87a91bc9f 100644 --- a/spec/models/budget/investment/milestone_spec.rb +++ b/spec/models/budget/investment/milestone_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe "Budget::Investment::Milestone" do +describe Budget::Investment::Milestone do describe "Validations" do let(:milestone) { build(:budget_investment_milestone) } diff --git a/spec/models/letter_spec.rb b/spec/models/letter_spec.rb index eca9f815e..3b9d37238 100644 --- a/spec/models/letter_spec.rb +++ b/spec/models/letter_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe 'Verification::Letter' do +describe Verification::Letter do let(:user) { create(:user) } diff --git a/spec/models/poll/booth_assignment_spec.rb b/spec/models/poll/booth_assignment_spec.rb index 9ea1fd516..1d2920abb 100644 --- a/spec/models/poll/booth_assignment_spec.rb +++ b/spec/models/poll/booth_assignment_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe :booth_assignment do +describe Poll::BoothAssignment do let(:poll){create(:poll)} let(:booth){create(:poll_booth)} let(:booth1){create(:poll_booth)} @@ -26,4 +26,4 @@ describe :booth_assignment do expect(Poll::Shift.all.count).to eq(0) end -end \ No newline at end of file +end diff --git a/spec/models/poll/booth_spec.rb b/spec/models/poll/booth_spec.rb index 8c2729c79..db0c1924b 100644 --- a/spec/models/poll/booth_spec.rb +++ b/spec/models/poll/booth_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe :booth do +describe Poll::Booth do let(:booth) { build(:poll_booth) } @@ -45,4 +45,4 @@ describe :booth do end end -end \ No newline at end of file +end diff --git a/spec/models/poll/officer_assignment_spec.rb b/spec/models/poll/officer_assignment_spec.rb index b6bce5481..e06b7f177 100644 --- a/spec/models/poll/officer_assignment_spec.rb +++ b/spec/models/poll/officer_assignment_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe :officer_assignment do +describe Poll::OfficerAssignment do it "should log user data on creation" do user = create(:user, username: "Larry Bird", email: "larry@lege.nd") officer = create(:poll_officer, user: user) @@ -9,4 +9,4 @@ describe :officer_assignment do expect(oa.reload.user_data_log).to eq "#{user.id} - Larry Bird (larry@lege.nd)" end -end \ No newline at end of file +end diff --git a/spec/models/poll/officer_spec.rb b/spec/models/poll/officer_spec.rb index b096aebc3..258427d1e 100644 --- a/spec/models/poll/officer_spec.rb +++ b/spec/models/poll/officer_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe :officer do +describe Poll::Officer do describe "#voting_days_assigned_polls" do it "should return all polls with this officer assigned during voting days" do @@ -121,4 +121,4 @@ describe :officer do expect(assigned_polls.last).to eq(poll_3) end end -end \ No newline at end of file +end diff --git a/spec/models/poll/shift_spec.rb b/spec/models/poll/shift_spec.rb index cba4285ae..2f6b79cab 100644 --- a/spec/models/poll/shift_spec.rb +++ b/spec/models/poll/shift_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe :shift do +describe Poll::Shift do let(:poll) { create(:poll) } let(:booth) { create(:poll_booth) } let(:user) { create(:user, username: "Ana", email: "ana@example.com") } diff --git a/spec/models/poll/voter_spec.rb b/spec/models/poll/voter_spec.rb index ae0f84a49..d92925b09 100644 --- a/spec/models/poll/voter_spec.rb +++ b/spec/models/poll/voter_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe :voter do +describe Poll::Voter do let(:poll) { create(:poll) } let(:booth) { create(:poll_booth) } diff --git a/spec/models/vote_spec.rb b/spec/models/vote_spec.rb index 25fd069f2..f29fe95b2 100644 --- a/spec/models/vote_spec.rb +++ b/spec/models/vote_spec.rb @@ -1,6 +1,6 @@ require 'rails_helper' -describe 'Vote' do +describe Vote do describe '#for_debates' do it 'does not returns votes for other votables' do diff --git a/spec/views/welcome/index.html.erb_spec.rb b/spec/views/welcome/index.html.erb_spec.rb index d8738f42b..7d01dede0 100644 --- a/spec/views/welcome/index.html.erb_spec.rb +++ b/spec/views/welcome/index.html.erb_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe "welcome/index" do +RSpec.describe "welcome#index" do it 'Display images on orbit carrousel when we have defined image_default' do debate = create(:debate)